actix-extras icon indicating copy to clipboard operation
actix-extras copied to clipboard

Added function to create an empty session for testing

Open kingledion opened this issue 2 years ago • 4 comments

PR Type

Feature

PR Checklist

  • [ ] Tests for the changes have been added / updated. (Not applicable, no tests existed)
  • [x] Documentation comments have been added / updated.
  • [x] A changelog entry has been made for the appropriate packages.
  • [x] Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

Added a Session::empty() function which instantiates an empty session to simplify unit testing.

None expected

Closes #252

kingledion avatar Jun 10 '22 23:06 kingledion

I dunno what to say about this. I can't replicate these build failures locally, and they also appear to be in actix-cors which I didn't change.

I tested a variety of ways that edition 2021/2018 and rust 1.54/1.60 may have interacted to cause a dependency issues, and I can't find anything.

The download of hashbrown failure may be an availability issue? Perhaps the solution is to re-run pipeline? I don't see that I can trigger it again...

kingledion avatar Jun 20 '22 16:06 kingledion

Nah, hashbrown started to use edition 2021 and it means we have to bump up our MSRV to 1.56. I'll handle it later so you don't have to worry about it.

JohnTitor avatar Jun 20 '22 22:06 JohnTitor

#233 is a big change and will likely conflict with this MR but I'd like to get it merged first (very soon).

robjtede avatar Jul 03 '22 00:07 robjtede

I can believe that a function like this is still useful after the overhaul but I'd like to see a test added demonstrating one or two use cases.

robjtede avatar Jul 19 '22 01:07 robjtede