activist icon indicating copy to clipboard operation
activist copied to clipboard

map: attribution not fully responsive

Open wkyoshida opened this issue 5 months ago • 3 comments

Terms

Behavior

Noticed that the map attribution is not quite fully responsive. The following main points were observed:


  • In dark mode, parts of the attribution are unreadable due to the text color:

image

..which was unfortunately overlooked, as that wasn't the case in local development and in the preview for PR #949:

image


  • Depending on screen size, the attribution can also sometimes sit on top of the Clear directions [x] custom control that we have on the bottom-left corner of the map:

image

..on this point, something that I'm considering is actually moving the Clear directions [x] custom control. Perhaps it could make sense to place it right under the route profile toggle button? The protruding size of the custom control might also not be an issue if a button to hide it is also implemented (as proposed in #960 - in the same vein as how the attribution control works).


  • Finally, not quite a fan of how the attribution wraps to fit in the text honestly... As we see in the below screenshot:

image ..only the word France is pushed down to the second line to fit everything. It could be more interesting if that entire segment of the attribution had been pushed down, e.g. in this case, CyclOSM tiles hosted by OpenStreetMap France so that the attribution might have looked something like:

MapLibre | © OpenStreetMap contributors |
CyclOSM tiles hosted by OpenStreetMap France

This point though is perhaps a little more tricky to wholy address. It also could simply be me being a bit too nitpicky :sweat_smile: so fully open to reconsideration. Mentioning this as I'm actually fine if this third point is set aside.

wkyoshida avatar Sep 02 '24 02:09 wkyoshida