activist
activist copied to clipboard
Fix #579: Add shadow to sidebar footer when content is scrollable
Contributor checklist
- [x] This pull request is on a separate branch and not the main branch
Description
This pull request addresses issue #579 by implementing a shadow effect on the sidebar footer when the content of the sidebar (either index or filters) is scrollable.
Changes made:
- Updated
SidebarLeftFooter.vueto accept a new propcontentIsScrollableand apply a shadow when it's true. - Modified
SidebarLeftIndex.vueandSidebarLeftFilters.vueto detect when their content is scrollable and emit this information. - Updated the parent component
SidebarLeft.vueto pass the scrollable state from the index and filters components to the footer component.
Additional notes:
The changes primarily affect the following components:
SidebarLeftFooter.vueSidebarLeftIndex.vueSidebarLeftFilters.vueSidebarLeft.vue
Related issue
- #579
Thank you for the pull request!
The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
Maintainer checklist
-
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local activist repo
-
[ ] The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed
-
[ ] The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)
-
[ ] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Deploy Preview for activist-org ready!
| Name | Link |
|---|---|
| Latest commit | 41e69aa47f0215e8b5e2526fd5a6c42fdf1584c4 |
| Latest deploy log | https://app.netlify.com/sites/activist-org/deploys/667e930184ea9b00089b8c7b |
| Deploy Preview | https://deploy-preview-910--activist-org.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hey @PustakP 👋 Could you take a screenshot of the change you made and send it along? Also, if you'd like to work on the linting errors, let me know! Can also handle them for you if you'd prefer 😊
I can also take care of the merge conflict as well. No stress 😎
@andrewtavis Hi! Thank you for your response, super excited for this. I'll be out of town for a few days so I can't send through a screenshot right now, but I can start on the merge conflicts as soon as Tuesday. Thanks!
Thank you, @PustakP! Looking forward to working on this with you further :)
Hey @PustakP 👋 Checking in on this again :) Would be great to get a screenshot of the change that this is sending along. Also happy to do a quick call at some point if that would be helpful!
Hey @PustakP 👋 Closing this out :) Please feel free to send along another PR :) It would be great to get a screenshot of the change involved, if you choose to open a new one 😊