activist icon indicating copy to clipboard operation
activist copied to clipboard

Modal view for all organizations involved in an event

Open andrewtavis opened this issue 10 months ago β€’ 40 comments

Terms

Description

In line with the general designs of activist where modals are used to show further information, it'd be great if we could create a modal ModalOrganizationOverview.vue that would house a scrollable flex col list of all organizations that are involved in an event. This modal would be triggered by clicking (+# more) on events on the About page as seen in the Figma designs.

Testing for this can be done on the test events page at events/ANY_NUMBER/about. This component would use ModalBase as its base, with the (+# more) being the normalDisplay and the flex col display of organization names and their icons to the left would be the modal.

Contribution

Happy to discuss the implementation for this or get to it myself eventually 😊

andrewtavis avatar Apr 15 '24 06:04 andrewtavis

I would like to pick this up

tasawar-hussain avatar May 05 '24 10:05 tasawar-hussain

Thanks, @tasawar-hussain! Would be great to get some help here :) Do your best with the styling, and I'll clean it up in review if need be 😊 Let us know if there's anything we can do to help!

andrewtavis avatar May 05 '24 10:05 andrewtavis

Hey @tasawar-hussain πŸ‘‹ Let us know if there's anything we can do to support here :) There's no pressure on this for the coming weeks, but it will start to be more pressing in July 😊

andrewtavis avatar May 18 '24 16:05 andrewtavis

Hey @tasawar-hussain πŸ‘‹ I'm going to unassign this one and #870 so that others can try, but please let me know if you'd like to be reassigned one of them. Hope you're well!

andrewtavis avatar Jul 09 '24 11:07 andrewtavis

Hello @andrewtavis can I take up this issue?

rahulharpal1603 avatar Sep 05 '24 06:09 rahulharpal1603

Sure thing, @rahulharpal1603! Please let us know if there are any questions 😊 As of now you'll likely need to create an event in the DB to test this, but hopefully in the coming days we'll get fixtures up so that you can work directly without creating events yourself. You can start orienting yourself to the project, and hopefully the events will be there for you to start working on this?

andrewtavis avatar Sep 05 '24 06:09 andrewtavis

Sure thing, @rahulharpal1603! Please let us know if there are any questions 😊 As of now you'll likely need to create an event in the DB to test this, but hopefully in the coming days we'll get fixtures up so that you can work directly without creating events yourself. You can start orienting yourself to the project, and hopefully the events will be there for you to start working on this?

I would be starting to work on this soon. I was busy with some pending PRs and college work.

rahulharpal1603 avatar Sep 15 '24 20:09 rahulharpal1603

Sounds good, @rahulharpal1603! We're quite close on the fixtures. Was a bit held up with other projects, but moving back here now :)

Let me know if you have any questions setting the project up!

andrewtavis avatar Sep 15 '24 20:09 andrewtavis

Hi @andrewtavis , Can I take up this issue ?

Siddharthgup avatar Sep 22 '24 05:09 Siddharthgup

@rahulharpal1603 is working on this one, @Siddharthgup :) Do you want me to suggest other issues you could check out?

@rahulharpal1603, the fixtures will be merged in with #977! Let us know if there are any questions 😊

andrewtavis avatar Sep 22 '24 05:09 andrewtavis

@andrewtavis I finished setting up the local environment using Docker, but how to enter the actual website from this page?:

image

rahulharpal1603 avatar Sep 22 '24 06:09 rahulharpal1603

It'll be more clear after this evening, @rahulharpal1603 :) I'll bring in the PR, which will also include directions for how to access the platform 😊

andrewtavis avatar Sep 22 '24 08:09 andrewtavis

Okay, thanksπŸ™

rahulharpal1603 avatar Sep 22 '24 08:09 rahulharpal1603

It'll be more clear after this evening, @rahulharpal1603 :) I'll bring in the PR, which will also include directions for how to access the platform 😊

Now can I access the page?

Also, I wanted to ask if this project can have the "hacktoberfest" topic attached to it. Also a "hacktoberfest" label to this issue? I have registered for Hacktober Fest and this PR could help me complete one of my 4 open-source contributions πŸ˜ƒ.

https://hacktoberfest.com/participation/#maintainers

Also, adding that topic to this project can bring in new contributors to accelerate the development cycle πŸ˜€

rahulharpal1603 avatar Sep 24 '24 03:09 rahulharpal1603

Now can I access the page?

Not quite yet, but hopefully this evening :)

We are participating in Hacktoberfest, and I'll update the repo now with the Hacktoberfest topic. We don't need to add the label to this issue, but your PR will be marked with it. Remember to open it after October starts though!

andrewtavis avatar Sep 24 '24 06:09 andrewtavis

Now can I access the page?

Not quite yet, but hopefully this evening :)

We are participating in Hacktoberfest, and I'll update the repo now with the Hacktoberfest topic. We don't need to add the label to this issue, but your PR will be marked with it. Remember to open it after October starts though!

Okay πŸ˜ƒ

rahulharpal1603 avatar Sep 24 '24 06:09 rahulharpal1603

Saw that they do want us marking the issues with the tags this year :)

andrewtavis avatar Sep 24 '24 06:09 andrewtavis

Hey @rahulharpal1603 πŸ‘‹ The factories have been loaded in, and there are now View organizations and View events buttons on the landing page to take you to the app. There is event page content that you can get to by click on the events, but it's not populated by the backend just yet. With that being said, maybe you can start working on the component on frontend/pages/events/[id]/about.vue and from there we can make sure that that page is getting data hydrated as soon as we can 😊

andrewtavis avatar Sep 25 '24 00:09 andrewtavis

Note @rahulharpal1603 that the component should be its own file, but it will appear on the page I specified :)

andrewtavis avatar Sep 25 '24 06:09 andrewtavis

Edited the above as that grid component doesn't exist. It should be in CardAboutEvent.vue :)

andrewtavis avatar Sep 25 '24 06:09 andrewtavis

@andrewtavis

Is there a way to create an event in my local dev. environment.?

rahulharpal1603 avatar Sep 25 '24 06:09 rahulharpal1603

Yes, @rahulharpal1603 :) I was also noting that the new generated events don't work for you as they're all one organization events. Go to localhost:8000, the backend port, and then log in with admin admin for the dev user and pass. From there you can add things into the backend via the Django admin UI 😊

andrewtavis avatar Sep 25 '24 06:09 andrewtavis

Yes, @rahulharpal1603 :) I was also noting that the new generated events don't work for you as they're all one organization events. Go to localhost:8000, the backend port, and then log in with admin admin for the dev user and pass. From there you can add things into the backend via the Django admin UI 😊

I tried accesssing that, but it returns this error: image

Although the backend is running: image

This is probably due to these errors, the backend is exiting: image

rahulharpal1603 avatar Sep 25 '24 07:09 rahulharpal1603

Can you check that you have topics.json locally? You've pulled the most recent changes and update your branch with them?

andrewtavis avatar Sep 25 '24 07:09 andrewtavis

Can you check that you have topics.json locally? You've pulled the most recent changes and update your branch with them?

Yes, I have the topics.json locally: image

rahulharpal1603 avatar Sep 25 '24 07:09 rahulharpal1603

How are you building the project? Can you try:

docker compose --env-file .env.dev up --build

andrewtavis avatar Sep 25 '24 07:09 andrewtavis

This will rebuild the project and hopefully also load in the topics :)

andrewtavis avatar Sep 25 '24 07:09 andrewtavis

This will rebuild the project and hopefully also load in the topics :)

Yeah, got it. I was not running with --build

rahulharpal1603 avatar Sep 25 '24 07:09 rahulharpal1603

Nice! Would you suggest maybe changing the directions to with --build and including a comment that says that build isn't required if there are no new dependencies? As of now we have the --build command in a comment below the base one πŸ€”

andrewtavis avatar Sep 25 '24 07:09 andrewtavis

Also considering the backend, I'm not sure if more than one organization is allowed just yet, so you can make the modal for it showing just one :)

andrewtavis avatar Sep 25 '24 07:09 andrewtavis