activist icon indicating copy to clipboard operation
activist copied to clipboard

Favicon isn't showing up on some browsers

Open andrewtavis opened this issue 1 year ago • 8 comments

Terms

Behavior

I'm realizing that the favicon isn't showing up on some browsers. Specifically on Safari and on Brave we're not getting the favicon showing up, but instead it's just the default A or Ac depending on the browser.

Would be great if someone wanted to look into this! The file is frontend/public/favicon.svg, and the changes may need to take place in frontend/nuxt.config.

Happy to support someone on this! Can also look into it myself a bit later :)

andrewtavis avatar Dec 09 '23 10:12 andrewtavis

I can look into it

Jonath-z avatar Dec 09 '23 19:12 Jonath-z

But I can see the favicon Screenshot from 2023-12-09 21-31-29

Jonath-z avatar Dec 09 '23 19:12 Jonath-z

Thanks @Jonath-z! Glad to have the support for this :) What browser are you using that you can see it? For Safari I'm not seeing it on a Mac, and I wasn't seeing it for Brave on an iPad.

andrewtavis avatar Dec 09 '23 23:12 andrewtavis

@andrewtavis I can see in firefox and brave as well, I'm using Ubuntu 23.10

  • Brave Screenshot from 2023-12-10 06-37-53

  • Firefox Screenshot from 2023-12-10 06-37-24

Jonath-z avatar Dec 10 '23 04:12 Jonath-z

Hmmm 🤔 Let me check and maybe this isn't an issue we can deal with. Could be just a Brave for iPad and general Safari thing, although each had favicons from other sources.

andrewtavis avatar Dec 10 '23 06:12 andrewtavis

Thanks for helping us figure out that we need a png for Safari, @Roshanjossey! The most recent commits added in a png for light mode as well and also changed the routes. I changed the default path to point at the light mode one for now, as the first tries of getting the favicon to switch to dark mode based on Nuxt Color Mode were unsuccessful. On dark mode for Safari it's black over a generated white box, so not perfect, but getting there 😊

andrewtavis avatar Dec 27 '23 08:12 andrewtavis

i can look into it, can you assign me

nairvismaya avatar Aug 05 '24 10:08 nairvismaya

i can look into it, can you assign me

nairvismaya avatar Aug 05 '24 10:08 nairvismaya

Sure thing, thank you @nairvismaya! :) Let us know if there's anything we can do to help 😊

andrewtavis avatar Aug 05 '24 16:08 andrewtavis

Sure thing, thank you @nairvismaya! :) Let us know if there's anything we can do to help 😊

andrewtavis avatar Aug 05 '24 16:08 andrewtavis