lessmsi icon indicating copy to clipboard operation
lessmsi copied to clipboard

Italian language update

Open bovirus opened this issue 1 year ago • 6 comments

@mega5800 @activescott

:+1::tada: First off, thanks for taking the time to contribute! :tada::+1:

Please fill out the following checklist:

  • [ ] Added tests for any bug fixes that changed existing code
  • [ ] Added tests for any new behavior
  • [X ] All unit tests are passing (please make sure all tests are passing for your branch/PR at https://ci.appveyor.com/project/activescott/lessmsi/history )

If you need any help at all, feel free to submit the PR and @-mention activescott and I'll be happy to assist!

bovirus avatar Oct 05 '24 16:10 bovirus

Hello @bovirus.

Let me help you with updating the tests as you changed the displayed Italian text.

mega5800 avatar Oct 05 '24 16:10 mega5800

@bovirus, here is the place you need to update: https://github.com/activescott/lessmsi/blob/18356d0b08ca1d026bd76ac0cdfe5f0b25da8e5b/src/Lessmsi.Tests/GUITests.cs#L50

I believe you only need to update the tests in lines 51-52, by providing the updated Italian texts for these tests.

mega5800 avatar Oct 05 '24 17:10 mega5800

@mega5800

Sorry but I didin't understanmd what strings I should update.

bovirus avatar Oct 06 '24 07:10 bovirus

@bovirus,

In the GUITests.cs file perform the next changes:

  1. Line 51: Change this line from: Assert.Equal("Selziona &Tutto", form.btnSelectAll.Text); To: Assert.Equal("Seleziona &tutto", form.btnSelectAll.Text);

  2. Line 52: Change this line from: Assert.Equal("&Deseleziona Tutto", form.btnUnselectAll.Text); To: Assert.Equal("&Deseleziona tutto", form.btnUnselectAll.Text);

Hope this helps.

mega5800 avatar Oct 06 '24 16:10 mega5800

@mega5800

Selziona &Tutto -> Seleziona &tutto

But GUITests.cs is not master file tht should have strings in English?

bovirus avatar Oct 07 '24 05:10 bovirus

@bovirus,

As the name suggests, GUITests.cs is a file for testing the GUI, nothing to do with master English strings. Please, apply the changes I suggested in my previous comment, which I updated according to your Italian translation.

If you have any difficulties doing so, please open a ticket with the changes you've made so far, your desired behaviour and I will take care of that.

mega5800 avatar Oct 07 '24 15:10 mega5800

I'm closing this one since it appears to be stale. If ya'll want to work on it though feel free to re-open it or open a new one.

activescott avatar Dec 19 '24 18:12 activescott

@activescott

Sorry for the delay. For me all is OK.

bovirus avatar Dec 19 '24 19:12 bovirus