squeel icon indicating copy to clipboard operation
squeel copied to clipboard

Published 20 hours ago • verified publisher icon activerecord-hackery

refactor collapse_wheres method so that string based where clauses are h...

Open jorgevaldivia opened this issue 10 years ago • 5 comments

...andled

Fixes #361

jorgevaldivia avatar Feb 11 '15 21:02 jorgevaldivia

:+1: Is there anything that I can do to get this merged? We stumbled upon the same issue

valscion avatar Aug 25 '15 13:08 valscion

:+1: Actually it started to bother me as well. Would be great if it could get merged.

vellotis avatar Sep 18 '15 13:09 vellotis

@jorgevaldivia are you using this in prod? Any problems so far? Thanks for the PR btw.

jlhonora avatar Feb 26 '16 16:02 jlhonora

Is there anything that we are waiting for with this? @bigxiang

mckinnsb avatar Mar 03 '16 23:03 mckinnsb

I am using rails 4.2 and I noticed that just commenting out the collapse_where method solves the issue for me. I also noticed that only a few squeel tests fail when I comment out collapse_where and they seem like they may even be false alarms. See my comments here:

https://github.com/activerecord-hackery/squeel/issues/416#issuecomment-201965883

Full disclosure, I am not completely sure why collapse_where was added to begin with so i may be way off base.

Also, if we want to include a spec that reproduces the issue, I added one here:

https://github.com/viewthespace/squeel/commit/5571d4a96eb9d52f9427172acff6685b1692873f

thx!

kbaum avatar Mar 27 '16 01:03 kbaum