ransack Replace blueprints with FactoryBot and embedded Rails app

Replace blueprints with FactoryBot and embedded Rails app

Open scarroll32 opened this issue 2 years ago • 7 comments

The specs in Ransack are built around the Machinist gem which hasn't been updated for 9 years (and we are pinned to an even older version).

Additionally, the specs are setup in a very non-standard way.

A better approach would be to use an embedded dummy Rails app and FactoryBot, see this for an example.

Jun 12 '22 14:06 scarroll32

Hey @scarroll32, if it possible i would like to try to refactor specs 🙏

Jul 12 '22 08:07 makketagg

Hey @scarroll32, if it possible i would like to try to refactor specs 🙏

@makketagg please go ahead and try. Thank you! 🙏

Jul 16 '22 22:07 scarroll32

@makketagg please let me know if you are actively working on this?

Jul 20 '22 02:07 scarroll32

@scarroll32 in progress 👌

Jul 20 '22 05:07 makketagg

Any update on this @makketagg ?

Nov 21 '22 15:11 scarroll32

@scarroll32 hello, sorry for delay and unclear status. I have no time for this right now :(

Nov 22 '22 08:11 makketagg

No problem @makketagg thanks for letting me know.

Nov 22 '22 16:11 scarroll32