payment_icons icon indicating copy to clipboard operation
payment_icons copied to clipboard

Adding finshark icon

Open robbanp opened this issue 1 year ago • 2 comments

Why are you adding this icons?

I'm adding/updating this icon(s) because this payment method is already supported by our Payment gateway

Help us identify yourself

  • [x] I'm working/collaborating with the brand directly and they have provided the icons.
  • [ ] I'm associated with the brand and I've read all the brand icon’s guidelines.
  • [ ] I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines: <Link>

Checklist to add new icons

  • [x] All icons have a corresponding entry in db/payment_icons.yml
  • [x] I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • [x] I have optimized the icon with SVGO
  • [x] I am confident that all icons are clear and easy to read/understand
  • [ ] I have provided a link to the brand icon’s brand guidelines whenever possible.
  • [x] I have attached a screenshot comparison with the example icon provided in guidelines
  • [x] I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

Tips how to create a screenshot

We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

<!-- Change background color if needed to showcase your icon better -->
<style> body { background: black; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<svg viewBox="0 0 38 24"  width="38" height="24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>

<!-- TODO: insert your icon here -->
<YOUR SVG CODE>

<br>
<!-- TODO: insert your icon here -->
<svg role="img" viewBox="0 0 38 24" width="38" height="24" aria-labelledby="pi-finshark" version="1.1" id="pi-finshark-svg22" xmlns="http://www.w3.org/2000/svg"><title id="pi-finshark">Finshark Open Banking</title><defs id="pi-finshark-defs22"><clipPath id="pi-finshark-clip0_18_5683"><path fill="#fff" id="pi-finshark-rect63" d="M0 0h96v32H0z"/></clipPath></defs><path fill="#000" opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z" id="pi-finshark-path1"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32" id="pi-finshark-path2"/><path id="pi-finshark-Tracciato_19920" data-name="Tracciato 19920" d="M25.19 18.386a18.537 18.537 0 01.212 2.809 17.861 17.861 0 01-9.356-2.509 17.869 17.869 0 01-9.357 2.509 18.537 18.537 0 01.212-2.809 15.912 15.912 0 009.144-3.043 15.905 15.905 0 009.145 3.043z" fill="#011025" stroke-width=".287"/><path id="pi-finshark-Tracciato_19921" data-name="Tracciato 19921" d="M25.402 2.478a17.853 17.853 0 01-2.509 9.357 18.509 18.509 0 011.91 4.666 13.832 13.832 0 01-3.07-.475 15.702 15.702 0 00-2.184-4.19 15.37 15.37 0 002.736-6.242 15.904 15.904 0 00-11.928 10.432 13.831 13.831 0 01-3.074.475A18.718 18.718 0 0125.402 2.478z" fill="#011025" stroke-width=".287"/></svg>
</br

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)

What's the expected date of this change to deploy on Shopify?

robbanp avatar Sep 11 '23 08:09 robbanp

Hi @robbanp ,

Could you please rebase this branch with activemerchant/master to resolve the conflicts.

Thanks

adeniyiao avatar Sep 19 '23 16:09 adeniyiao

Hi @robbanp, could you please rebase this branch with activemerchant/master to resolve the conflicts? We won't be able to move forward until this is completed.

Thanks

dannye0231 avatar May 09 '24 16:05 dannye0231

Hi @robbanp, are you able to re-base today? We will be doing another release tomorrow and can include this change if its re-based in time.

Thanks

dannye0231 avatar Jul 30 '24 20:07 dannye0231