New Icons

[thejoshualewis]

** Checklist **

• [ x] All icons have a corresponding entry in db/payment_icons.yml
• [x ] I have followed the icon guidelines detailed in the CONTRIBUTING.md file
• [ x] I have optimized the icon with SVGO
• [ x] I am confident that all icons are clear and easy to read/understand
• [ x] I have provided a link to the brand icon’s brand guidelines whenever possible.

https://bitpay.com/about/brand If this pull request is not adding new icons, you can remove this checklist.

[thejoshualewis]

hi @tauthomas01 , I removed all the id's I can without ruining the svg, and optimized with svgo

[tauthomas01]

Hi @thejoshualewis ,

• The dimension is invalid. Please see the contribution guideline

The "bitpay" currencies icon include 4 icons in 1 file, which does not follow the guideline.

• We already have Bitcoin (https://github.com/activemerchant/payment_icons/blob/8049e703143d789b92a1bf7358751a18ce213df6/app/assets/images/payment_icons/bitcoin.svg)
• We already have Bitcoin cash (https://github.com/activemerchant/payment_icons/blob/8049e703143d789b92a1bf7358751a18ce213df6/app/assets/images/payment_icons/bitcoin_cash.svg)
• The dimensions are invalid. It needs a width of 38 and height of 24

[thejoshualewis]

Hi @tauthoms01,

This is to replace those icons, and have the 4 as the standard, to show users the different types accepted.

On Thu, Apr 23, 2020 at 10:49 AM tauthomas01 [email protected] wrote:

Hi @thejoshualewis https://github.com/thejoshualewis ,

• The dimension is invalid. Please see the contribution guideline http://url

The "bitpay" currencies icon include 4 icons in 1 file.

• We already have Bitcoin ( https://github.com/activemerchant/payment_icons/blob/8049e703143d789b92a1bf7358751a18ce213df6/app/assets/images/payment_icons/bitcoin.svg )
• We already have Bitcoin cash ( https://github.com/activemerchant/payment_icons/blob/8049e703143d789b92a1bf7358751a18ce213df6/app/assets/images/payment_icons/bitcoin_cash.svg )
• The dimensions are invalid. It needs a width of 38 and height of 24

[image: alt] https://screenshot.click/23-44-qoaes-51hxy.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/activemerchant/payment_icons/pull/227#issuecomment-618439201, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC75BDX6DRK5QNZVZJY2UDROBIOXANCNFSM4KXGYWDQ .

[tauthomas01]

Hi @thejoshualewis,

If that's the case, all 4 icons should be in their own file, not together.

[thejoshualewis]

Hi @tauthomas01

It should be the same as https://bitpay.com/cdn/en_US/bitpay-mark-std.svg https://bitpay.com/cdn/en_US/bitpay-mark-std.svg

One image with our base currencies that we use on our branding https://bitpay.com/about/brand https://bitpay.com/about/brand

On Apr 23, 2020, at 1:33 PM, tauthomas01 [email protected] wrote:

Hi @thejoshualewis https://github.com/thejoshualewis,

If that's the case, all 4 icons should be in their own file, not together.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/activemerchant/payment_icons/pull/227#issuecomment-618537437, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC75BCMSPTFLWAUQGXDMWLROB3VVANCNFSM4KXGYWDQ.

[tauthomas01]

Hi @thejoshualewis

I understand what you're trying to do, but in order to keep consistencies and the rules of this repository, we need to follow the guideline like any other icons.

Here are a few examples that demonstrate what I mean: https://github.com/activemerchant/payment_icons/blob/master/app/assets/images/payment_icons/eghl.svg https://github.com/activemerchant/payment_icons/blob/master/app/assets/images/payment_icons/amazon.svg

I can't go forward by simply adding this => https://bitpay.com/cdn/en_US/bitpay-mark-std.svg

[thejoshualewis]

So to have the layout with the mark + 4 icons, those all need to be individual? And Shopify will add all 4 manually instead of 1 link? Just trying to clarify the right way to do this.

On Apr 23, 2020, at 2:27 PM, tauthomas01 [email protected] wrote:

Hi @thejoshualewis https://github.com/thejoshualewis I understand what you're trying to do, but in order to keep consistencies and the rules of this repository, we need to follow the guideline like any other icons.

Here are a few examples that demonstrate what I mean: https://github.com/activemerchant/payment_icons/blob/master/app/assets/images/payment_icons/eghl.svg https://github.com/activemerchant/payment_icons/blob/master/app/assets/images/payment_icons/eghl.svg https://github.com/activemerchant/payment_icons/blob/master/app/assets/images/payment_icons/amazon.svg https://github.com/activemerchant/payment_icons/blob/master/app/assets/images/payment_icons/amazon.svg I can't go forward by simply adding this => https://bitpay.com/cdn/en_US/bitpay-mark-std.svg https://bitpay.com/cdn/en_US/bitpay-mark-std.svg — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/activemerchant/payment_icons/pull/227#issuecomment-618572054, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC75BCG3FIJYY5GUAUWI33ROCCALANCNFSM4KXGYWDQ.

[tauthomas01]

Exactly, you'll create 4 individual icons. All instructions are included here: https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md#guidelines-for-new-icons

Here's the current list of icons, that will give you an idea how it looks like: https://github.com/activemerchant/payment_icons/tree/master/app/assets/images/payment_icons

[rahilvirani]

Closing the PR because it has been stale for a while. If the change is still relevant, please re-create the pull request using the new pull request template. We are sorry for the inconvenience.