payment_icons icon indicating copy to clipboard operation
payment_icons copied to clipboard

Simpl Payments Icon

Open mrinalika-ghosh opened this issue 10 months ago • 10 comments

Why are you adding this icons?

I'm adding/updating this icon(s) because Simpl Payments offers Pay Later & Pay in 3 solutions to customers in India (https://getsimpl.com/). This is a payment method offered on Shopify via Simpl Payments App today

Help us identify yourself

  • [x] I'm working/collaborating with the brand directly and they have provided the icons.
  • [ ] I'm associated with the brand and I've read all the brand icon’s guidelines.
  • [ ] I'm an individual and I've read all the brand icon’s guidelines. Link to the brand guidelines: <Link>

Checklist to add new icons

  • [x] All icons have a corresponding entry in db/payment_icons.yml
  • [x] I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • [x] I have optimized the icon with SVGO
  • [x] I am confident that all icons are clear and easy to read/understand
  • [ ] I have provided a link to the brand icon’s brand guidelines whenever possible.
  • [x] I have attached a screenshot comparison with the example icon provided in guidelines
  • [x] I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger. If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

screenshot #### Tips how to create a screenshot We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder. screenshot ``` Visa

mrinalika-ghosh avatar Apr 02 '24 10:04 mrinalika-ghosh

Hi @Mrinalika Is it only the Simpl logo you're trying to add? If that's the case you don't need to upload icons for the other 3. The icon is also the incorrect size. Please refer to our image for more information.

hellicarusprime avatar Apr 02 '24 12:04 hellicarusprime

Hi Michael, I have updated the code as requested. Can you please check again?

mrinalika-ghosh avatar Apr 03 '24 11:04 mrinalika-ghosh

Hi @mrinalika-ghosh, the icon still isn't the right size, but it looks like I accidentally missed the link to our contributing guidelines in my last message. Refer to these to ensure your icon is correct.

hellicarusprime avatar Apr 03 '24 11:04 hellicarusprime

Hi @hellicarusprime, We have updated again the file. Can you please check the latest *.svg file now.

mrinalika-ghosh avatar Apr 04 '24 10:04 mrinalika-ghosh

Hi @Mrinalika, the size of the icon you added is 40 x 26—it should be 38 x 24. The visible border should be included.

hellicarusprime avatar Apr 08 '24 10:04 hellicarusprime

@hellicarusprime - Updated

mrinalika-ghosh avatar Apr 09 '24 04:04 mrinalika-ghosh

Hi @mrinalika-ghosh, there are still a couple of issues with the icon. Please refer to our contributing guidelines to address these.

Issues:

  • The name of the SVG must be the same as the name entered in db/payment_icons.yml
  • The border must have a 2px radius (outside stroke)

hellicarusprime avatar Apr 09 '24 09:04 hellicarusprime

@hellicarusprime Apologies for the back and forth. Hope this time we were able to make the required changes.

mrinalika-ghosh avatar Apr 10 '24 07:04 mrinalika-ghosh

The icon looks good now @mrinalika-ghosh, but you have some conflicts that need to be resolved.

hellicarusprime avatar Apr 10 '24 08:04 hellicarusprime

Hey! Thanks, @hellicarusprime - are there any other tasks for me to complete? Also, when will this show up in the Shopify Payment Icons as an option?

mrinalika-ghosh avatar Apr 10 '24 09:04 mrinalika-ghosh

@hellicarusprime Just wanted to check since the test has failed. Are we supposed to make any changes?

mrinalika-ghosh avatar Apr 12 '24 06:04 mrinalika-ghosh

@hellicarusprime Just wanted to check since the test has failed. Are we supposed to make any changes?

Cc: @adeniyiao

hellicarusprime avatar Apr 12 '24 08:04 hellicarusprime

Have resolved the conflicts again @hellicarusprime Let me know in case we are suppose to update anything else from our end

mrinalika-ghosh avatar Apr 16 '24 04:04 mrinalika-ghosh

@Lovedanihonjin : Can you please check once now?

mrinalika-ghosh avatar Apr 23 '24 14:04 mrinalika-ghosh

Resolved the above error

mrinalika-ghosh avatar Apr 25 '24 01:04 mrinalika-ghosh

@Lovedanihonjin : Let me know if still I am missing anything in my latest commit?

mrinalika-ghosh avatar Apr 29 '24 12:04 mrinalika-ghosh

@Lovedanihonjin : Have made the changes again. Let me know if anything else needed from my end.

mrinalika-ghosh avatar May 07 '24 05:05 mrinalika-ghosh