active_merchant icon indicating copy to clipboard operation
active_merchant copied to clipboard

ECS-3530 Adyen Format error fix

Open jherreraa opened this issue 1 year ago • 3 comments

ECS-3530

Summary:

This PR fix format error using NT

Unit tests

Finished in 0.126432 seconds.

121 tests, 641 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Remote tests

Finished in 609.957316 seconds.

143 tests, 464 assertions, 11 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 92.3077% passed

0.23 tests/s, 0.76 assertions/s

-> failures not related to change

jherreraa avatar Jun 25 '24 20:06 jherreraa

There's also a Rubocop error which is why the GitHub actions tests are failing

almalee24 avatar Jun 26 '24 16:06 almalee24

I added the conditional back into the app_mpi_data_for_network_tokenization_card method updating the cavv to tokenAuthenticationVerificationValue. It seems to me that the issue in the tests is with ApplePay and GooglePay. We need to be able to differentiate these from the standard network token flow, and continue to pass that value as cavv for apple pay and google pay.

Then we also need to continue to pass the existing recurring_contract info for apple_pay and google pay and only update that when it is a pure network token.

cc: @almalee24 @jherreraa

DustinHaefele avatar Jul 08 '24 14:07 DustinHaefele

Great work on this one Johan, I know this framework can be a bit tricky!

DustinHaefele avatar Jul 16 '24 20:07 DustinHaefele