active_merchant icon indicating copy to clipboard operation
active_merchant copied to clipboard

RedsysRest: Add new gateway

Open varyonic opened this issue 3 years ago • 1 comments

Resolves #3548

$ ruby -I lib -I test test/remote/gateways/remote_redsys_rest_test.rb
Loaded suite test/remote/gateways/remote_redsys_rest_test
Started
..............................
Finished in 43.361735 seconds.
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
30 tests, 116 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
0.69 tests/s, 2.68 assertions/s

varyonic avatar Sep 16 '22 17:09 varyonic

CI is failing on ArgumentError: invalid base64 Tried urlsafe_decode64 for cipher.key but I don't know what test credentials are being used.

varyonic avatar Sep 16 '22 18:09 varyonic

Marking this "of interest" before a cleanup of stale PRs

curiousepic avatar Oct 25 '23 17:10 curiousepic

Hi @varyonic thanks for putting this PR up and apologies for the delay in responding to it. We're working on a process to be more responsive to external contributors.

I'm running the remote tests for this PR and encountering an error of SIS0218 ERROR, did you run into this? Also would you mind rebasing on master?

aenand avatar Nov 07 '23 13:11 aenand

It’s been a year now since I worked on this and our need for this API has come and gone. The documentation site has been revised and 3DSv1 has been sunset.

If this is for use by Spreedly feel free to rebase and correct as needed. If Spreedly is not intending to maintain this then I’m happy to put activemerchant-redsys_rest up for adoption if anyone wants it.

varyonic avatar Nov 07 '23 22:11 varyonic

@varyonic good to know and thank you for your work! I will be creating a new branch to work off for this code request and add you as a co-author to the commit/changelog when updated. Would you like to be requested as a reviewer?

aenand avatar Nov 08 '23 14:11 aenand

To provide a cleaner slate for the maintenance of the library, this PR/Issue is being labeled stale after 60 days without activity. It will be closed in 14 days unless you comment with an update regarding its applicability to the current build. Thank you!

github-actions[bot] avatar Jan 10 '24 01:01 github-actions[bot]

Redsys Rest was added as a new gateway as part of PR #4951

aenand avatar Jan 24 '24 14:01 aenand