active_merchant Beanstream Gateway Improvements

Integrated the IPP gateway into the Beanstream gatewayand use BeanstreamGateway as the unified entrance;

remove IPP gateway files;

Because the two gateways belong to the same company just different branch. So the developers from the company hope to make them an unified gateway to Shopify.

(Beansteam website: http://www.beanstream.com/)

Apr 23 '18 01:04 lumiit-adam

looks good to me, @WizardCloud please squash commit

May 22 '18 16:05 elfassy

@elfassy squashed now

May 23 '18 05:05 lumiit-adam

@lumiit-adam can you post a link to the Beanstream docs in the description, thx

May 29 '18 13:05 elfassy

Hi, @elfassy I have split the committed code, please have a look.

Jun 04 '18 02:06 lumiit-adam

I have changed code, please continue to review.

Jun 20 '18 00:06 lumiit-adam

@elfassy is there anything outstanding before this can be merged into Master?

Jul 09 '18 02:07 chriswongipp

Finished squashing commit and waiting for final reviewing

Jul 19 '18 04:07 lumiit-adam

Any reason we must use the region option? Seems to me like it would be best to let the end user decide between BeanstreamDefautGateway and BeanstreamIppGateway . Each already provides the information as to where it can be used (https://github.com/activemerchant/active_merchant/pull/2813/files#diff-1db73f09eabc8b8a2be54b728f148ee9R7)

Aug 21 '18 15:08 elfassy