active_merchant icon indicating copy to clipboard operation
active_merchant copied to clipboard

Published 20 hours ago • verified publisher icon activemerchant

Orbital: accept order_id option for capture [#2247]

Open yaychris opened this issue 8 years ago • 6 comments

This commit resolves the issue identified in #2247.

yaychris avatar Oct 29 '16 16:10 yaychris

@jasonwebster Is this something you're still interested in landing?

bpollack avatar Jun 25 '18 01:06 bpollack

Hi! I'm interested in getting this PR merged, if that's still on the table, and I'd be happy to help if I can. I'm working with the iframe auth/server capture setup Chris described above, and it would be nice to be able to pass in the order id.

albaer avatar Jun 29 '18 16:06 albaer

Awesome, I'll look @albaer . I've been going through and cleaning up/landing a lot of PRs, but it's a slow burn. I'll try to get you feedback within the next week or so.

bpollack avatar Jun 29 '18 17:06 bpollack

@albaer What would you need to update this and help land it?

bpollack avatar Jul 11 '18 18:07 bpollack

I'm not sure. If adding this option is good with you, I can just rebase it, make sure everything is all set with contribution guidelines and documentation, and then let you know. How does that sound?

albaer avatar Aug 27 '18 16:08 albaer

@bpollack I was just talking to some coworkers, and they said they had this open. It's been rebased and should be ready to go. Let me know if there are any changes you would need to it.

joeyjoejoejr avatar Dec 04 '18 17:12 joeyjoejoejr