deeplake icon indicating copy to clipboard operation
deeplake copied to clipboard

[DL-716] Raise exception if dataset too large to delete

Open farizrahman4u opened this issue 3 years ago • 2 comments

🚀 🚀 Pull Request

Checklist:

  • [ ] My code follows the style guidelines of this project and the Contributing document
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have kept the coverage-rate up
  • [ ] I have performed a self-review of my own code and resolved any problems
  • [ ] I have checked to ensure there aren't any other open Pull Requests for the same change
  • [ ] I have described and made corresponding changes to the relevant documentation
  • [ ] New and existing unit tests pass locally with my changes

Changes

farizrahman4u avatar Sep 15 '22 13:09 farizrahman4u

Codecov Report

:exclamation: No coverage uploaded for pull request base (deeplake@90d5065). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Current head d91c9fa differs from pull request most recent head e37fc0a. Consider uploading reports for the commit e37fc0a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             deeplake    #1874   +/-   ##
===========================================
  Coverage            ?   91.96%           
===========================================
  Files               ?      245           
  Lines               ?    25618           
  Branches            ?        0           
===========================================
  Hits                ?    23560           
  Misses              ?     2058           
  Partials            ?        0           
Flag Coverage Δ
unittests 91.96% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 16 '22 05:09 codecov[bot]

@farizrahman4u the test fails is pretty strange

>           raise TransformError(e) from e
E           hub.util.exceptions.TransformError: cannot reshape array of size 100 into shape (98,1)

davidbuniat avatar Sep 19 '22 05:09 davidbuniat