deeplake icon indicating copy to clipboard operation
deeplake copied to clipboard

[BUGFIX] Stream video only if chunk size is greater than max_chunk_size

Open FayazRahman opened this issue 1 year ago • 1 comments

🚀 🚀 Pull Request

Checklist:

  • [ ] My code follows the style guidelines of this project and the Contributing document
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have kept the coverage-rate up
  • [ ] I have performed a self-review of my own code and resolved any problems
  • [ ] I have checked to ensure there aren't any other open Pull Requests for the same change
  • [ ] I have described and made corresponding changes to the relevant documentation
  • [ ] New and existing unit tests pass locally with my changes

Changes

Get more header bytes if enough bytes were not fetched at first in get_header_from_url

FayazRahman avatar Aug 18 '22 05:08 FayazRahman

Codecov Report

Merging #1822 (b8a6f97) into main (5ccebd9) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1822      +/-   ##
==========================================
- Coverage   92.87%   92.86%   -0.02%     
==========================================
  Files         231      231              
  Lines       24698    24690       -8     
==========================================
- Hits        22938    22928      -10     
- Misses       1760     1762       +2     
Flag Coverage Δ
unittests 92.86% <100.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/api/dataset.py 90.19% <ø> (+0.98%) :arrow_up:
hub/__init__.py 94.73% <100.00%> (ø)
hub/core/chunk_engine.py 94.94% <100.00%> (ø)
hub/core/serialize.py 97.46% <100.00%> (ø)
hub/util/exceptions.py 85.27% <100.00%> (+0.04%) :arrow_up:
hub/integrations/tests/test_pytorch_dataloader.py 95.69% <0.00%> (-2.16%) :arrow_down:
hub/integrations/pytorch/dataset.py 92.74% <0.00%> (-1.53%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 18 '22 07:08 codecov[bot]

closing for now

FayazRahman avatar Oct 19 '22 11:10 FayazRahman