deeplake
deeplake copied to clipboard
[AL-1858] Treat empty list as None
🚀 🚀 Pull Request
Checklist:
- [ ] My code follows the style guidelines of this project and the Contributing document
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have kept the
coverage-rate
up - [ ] I have performed a self-review of my own code and resolved any problems
- [ ] I have checked to ensure there aren't any other open Pull Requests for the same change
- [ ] I have described and made corresponding changes to the relevant documentation
- [ ] New and existing unit tests pass locally with my changes
Changes
- Empty lists now have the same behaviour as using None during appends and updates
Codecov Report
Merging #1813 (df529b8) into main (a6dca41) will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #1813 +/- ##
==========================================
+ Coverage 92.84% 92.86% +0.02%
==========================================
Files 230 231 +1
Lines 24541 24611 +70
==========================================
+ Hits 22784 22856 +72
+ Misses 1757 1755 -2
Flag | Coverage Δ | |
---|---|---|
unittests | 92.86% <100.00%> (+0.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
hub/__init__.py | 94.73% <100.00%> (+0.09%) |
:arrow_up: |
hub/api/tests/test_none.py | 100.00% <100.00%> (ø) |
|
hub/core/chunk_engine.py | 94.93% <100.00%> (+0.05%) |
:arrow_up: |
hub/core/transform/test_transform.py | 99.34% <100.00%> (+0.03%) |
:arrow_up: |
hub/util/bugout_reporter.py | 91.56% <100.00%> (+0.89%) |
:arrow_up: |
hub/util/empty_sample.py | 100.00% <100.00%> (ø) |
|
hub/util/casting.py | 85.13% <0.00%> (-1.36%) |
:arrow_down: |
hub/core/ipc.py | 0.00% <0.00%> (ø) |
|
hub/integrations/pytorch/dataset.py | 92.74% <0.00%> (+0.02%) |
:arrow_up: |
... and 8 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.