deeplake
deeplake copied to clipboard
changes for audio/video support in hub.ingest
🚀 🚀 Pull Request
Checklist:
- [ ] My code follows the style guidelines of this project and the Contributing document
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have kept the
coverage-rate
up - [ ] I have performed a self-review of my own code and resolved any problems
- [ ] I have checked to ensure there aren't any other open Pull Requests for the same change
- [ ] I have described and made corresponding changes to the relevant documentation
- [ ] New and existing unit tests pass locally with my changes
Changes
PR for issue #1556
Tagging @tatevikh for visibility.
Hi @neel2299 thanks for your contribution. We'll review it and get back to you:)
Hi @neel2299 . How is the progress with this PR? Do you need any help here? Pleas do let us know:)
Hi @tatevikh, thanks for reminding me. It skipped my mind that I had this PR open, I will get this done as soon as possible.
Codecov Report
Base: 92.60% // Head: 92.60% // Decreases project coverage by -0.00%
:warning:
Coverage data is based on head (
d26c5d8
) compared to base (72bc6b4
). Patch coverage: 82.14% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## main #1643 +/- ##
==========================================
- Coverage 92.60% 92.60% -0.01%
==========================================
Files 245 245
Lines 25984 26023 +39
==========================================
+ Hits 24063 24098 +35
- Misses 1921 1925 +4
Flag | Coverage Δ | |
---|---|---|
unittests | 92.60% <82.14%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
hub/auto/tests/test_ingestion.py | 98.71% <ø> (ø) |
|
hub/integrations/wandb/wandb.py | 48.05% <40.00%> (-0.21%) |
:arrow_down: |
hub/api/dataset.py | 89.45% <73.33%> (-0.92%) |
:arrow_down: |
hub/auto/unstructured/classification.py | 87.23% <82.35%> (ø) |
|
hub/__init__.py | 94.73% <100.00%> (ø) |
|
hub/compression.py | 97.95% <100.00%> (+0.23%) |
:arrow_up: |
hub/constants.py | 100.00% <100.00%> (ø) |
|
hub/core/compression.py | 89.64% <100.00%> (ø) |
|
hub/experimental/convert_to_hub3.py | 90.24% <100.00%> (+10.75%) |
:arrow_up: |
hub/experimental/test_pytorch.py | 99.21% <100.00%> (+0.01%) |
:arrow_up: |
... and 3 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@neel2299 Looks good so far, could you also tests for these? See this file for example: https://github.com/activeloopai/Hub/blob/main/hub/auto/tests/test_ingestion.py#L63
Dear @neel2299, agree with @FayazRahman, could you please add some tests? Lines of code that need tests are highlighted with codecove, you can take a look at it in Files Changed section
Makes sense @FayazRahman @adolkhan !! I will add them.
@neel2299 let me know if you'll be working on this otherwise I'll close this PR for now.
Closing for now.