deeplake icon indicating copy to clipboard operation
deeplake copied to clipboard

Added more file formats for compression

Open aadityasinha-dotcom opened this issue 2 years ago • 4 comments

🚀 🚀 Pull Request

Checklist:

  • [x] My code follows the style guidelines of this project and the Contributing document
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have kept the coverage-rate up
  • [ ] I have performed a self-review of my own code and resolved any problems
  • [x] I have checked to ensure there aren't any other open Pull Requests for the same change
  • [ ] I have described and made corresponding changes to the relevant documentation
  • [x] New and existing unit tests pass locally with my changes

Changes

  1. I have added more image file formats for compression.
  2. I have also added read-only formats for compression.

aadityasinha-dotcom avatar Apr 15 '22 13:04 aadityasinha-dotcom

@farizrahman4u can you review the changes?

aadityasinha-dotcom avatar Apr 15 '22 16:04 aadityasinha-dotcom

@farizrahman4u Can you review the changes I have made?

aadityasinha-dotcom avatar Apr 20 '22 00:04 aadityasinha-dotcom

@farizrahman4u Can you review the changes?

aadityasinha-dotcom avatar May 14 '22 05:05 aadityasinha-dotcom

@farizrahman4u any update?

aadityasinha-dotcom avatar Aug 05 '22 06:08 aadityasinha-dotcom

@aadityasinha-dotcom congrats on having an approved PR with us. Can you pls fix the failing tests, so we can merge your PR. Thanks!

tatevikh avatar Aug 15 '22 07:08 tatevikh

@aadityasinha-dotcom Just update the list in test_compressions_list in test_api.py and remove test for 'dcm' in test_array, test_multi_array and test_verify in test_compression.py.

FayazRahman avatar Aug 15 '22 09:08 FayazRahman

@FayazRahman Can you review the changes?

aadityasinha-dotcom avatar Aug 16 '22 15:08 aadityasinha-dotcom

Can you run black on the files and pull main branch? We should be good to merge this after it!

FayazRahman avatar Aug 17 '22 20:08 FayazRahman

Hey @FayazRahman can you check that I did black and pulled the main branch.

aadityasinha-dotcom avatar Aug 19 '22 13:08 aadityasinha-dotcom

@aadityasinha-dotcom test_compressions_list is still failing could you fix and run that test locally?

FayazRahman avatar Aug 22 '22 16:08 FayazRahman

Okay

aadityasinha-dotcom avatar Aug 22 '22 16:08 aadityasinha-dotcom

@aadityasinha-dotcom tests are still failing. This needs to be fixed, otherwise we cannot merge. Thank you!

tatevikh avatar Aug 31 '22 10:08 tatevikh

@aadityasinha-dotcom tests are still failing. This needs to be fixed, otherwise we cannot merge. Thank you!

Yes I will look into it.

aadityasinha-dotcom avatar Aug 31 '22 10:08 aadityasinha-dotcom

Hey @FayazRahman , why these tests are failing I tried to run test_tensorflow.py in my system but it was giving no errors.

aadityasinha-dotcom avatar Sep 17 '22 14:09 aadityasinha-dotcom

@aadityasinha-dotcom Can you pull main and try again?

FayazRahman avatar Sep 19 '22 08:09 FayazRahman

@FayazRahman I have pulled the main branch.

aadityasinha-dotcom avatar Sep 19 '22 14:09 aadityasinha-dotcom

Codecov Report

Base: 91.98% // Head: 92.21% // Increases project coverage by +0.22% :tada:

Coverage data is based on head (a6988ea) compared to base (d4f625f). Patch coverage: 76.92% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1597      +/-   ##
==========================================
+ Coverage   91.98%   92.21%   +0.22%     
==========================================
  Files         245      246       +1     
  Lines       25689    26104     +415     
==========================================
+ Hits        23631    24072     +441     
+ Misses       2058     2032      -26     
Flag Coverage Δ
unittests 92.21% <76.92%> (+0.22%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/api/tests/test_api.py 99.78% <ø> (+1.04%) :arrow_up:
hub/tests/path_fixtures.py 90.72% <ø> (+3.17%) :arrow_up:
hub/core/tests/test_readonly.py 64.70% <64.70%> (ø)
hub/compression.py 95.91% <100.00%> (-1.81%) :arrow_down:
hub/core/tests/test_compression.py 68.29% <100.00%> (-25.57%) :arrow_down:
hub/tests/common.py 91.04% <0.00%> (-5.98%) :arrow_down:
hub/core/compression.py 80.80% <0.00%> (-0.83%) :arrow_down:
hub/integrations/wandb/wandb.py 48.05% <0.00%> (-0.72%) :arrow_down:
... and 80 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 21 '22 10:09 codecov[bot]

Yaaaaay, @aadityasinha-dotcom - congrats on the contribution! Can you please hit me up in the community slack to arrange for some swag? :)

mikayelh avatar Sep 21 '22 15:09 mikayelh