stale icon indicating copy to clipboard operation
stale copied to clipboard

Updates to PRs linked to an issue should clear the stale attribute

Open jsoref opened this issue 2 years ago • 8 comments

The problem

  1. actions/stale said an issue was stale https://github.com/primer/view_components/issues/1033#issuecomment-1229120056 and marked it as stale https://github.com/primer/view_components/issues/1033#event-7271587943
  2. I made a PR that would close the issue https://github.com/primer/view_components/issues/1033#ref-pullrequest-1353408921
  3. The bot did not remove its stale marker
  4. I had to add an extra comment to the issue: https://github.com/primer/view_components/issues/1033#issuecomment-1230436001

The solution

Ideally the bot should be able to recognize that a PR exists and is linked to the issue and remove the stale annotation. As stale-bot runs on a schedule, it can have access to pull requests and can therefore check to see if there are stale-issues with linked PRs and then check to see if those PRs have been touched since it last ran, and then remove the stale notice.

jsoref avatar Aug 29 '22 15:08 jsoref

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] avatar Sep 29 '22 00:09 github-actions[bot]

👎

jsoref avatar Sep 29 '22 00:09 jsoref

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] avatar Oct 31 '22 00:10 github-actions[bot]

👎

jsoref avatar Oct 31 '22 00:10 jsoref

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] avatar Dec 02 '22 00:12 github-actions[bot]

👎

jsoref avatar Dec 02 '22 00:12 jsoref

In a similar vein, issue that have an open PR linked to them (like https://github.com/conda/conda-build/issues/3170) should not be marked stale at all, imo. Otherwise, stale bot would close an issue that has a PR currently waiting that closes it. If anything, the linked PR should be checked for staleness, as that has become the "upstream" datum of information concerning the issue in question.

bilderbuchi avatar Dec 05 '22 07:12 bilderbuchi

I'm kind of shocked that this isn't the default behavior. I switched to this action because I assumed it was. :frowning_face: In general if an issue has a linked PR, and that PR is active, that should be enough to keep the issue itself "alive".

dorner avatar Aug 10 '23 00:08 dorner