Stale label not removed after receiving comments/commit
Description:
I recently enabled the stable bot PR here. Yesterday I noticed a PR that clearly had updates, but the Stale label is still not removed from the PR. I looked into the PR and here is the timeline:
- Stable label added: 2024-01-26 16:19 GMT+1
- Comment from non-autor 2024-01-31 17:45 GMT+1
- New commit: 2024-01-30 14:50 GMT+1
That is also consistent with what it is shown in the logs:
Action version: 2.312.0
Platform:
- [x] Ubuntu
- [ ] macOS
- [ ] Windows
Runner type:
- [x] Hosted
- [ ] Self-hosted
Repro steps:
Last job execution: https://github.com/open-telemetry/semantic-conventions/actions/runs/7750945678/job/21137993067
Affected PR: https://github.com/open-telemetry/semantic-conventions/pull/627
Expected behavior:
The Stale label to be removed, since the PR received updates/activity:
- A comment from a non-author in an existing thread/discussion
- A new commit after the Stale label was added
Actual behavior:
The Stale label is there.
I'm not sure if I'm missing any configuration, but with the defaults it seems it should work:
If an update/comment occur on stale issues or pull requests, the stale label will be removed and the timer will restart
Another example here https://github.com/open-telemetry/semantic-conventions/pull/600
Hello @joaopgrassi Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.
Does the issue persist since you bumped the version?
I have not seen it anymore, but it could be that I'm just not looking hard enough. I will try to keep an eye and see if anything gets closed unintentionally.
I think I saw exactly the same issue in https://github.com/instaloader/instaloader/issues/2172. I replied to prevent the bot from closing the issue, but it closed it nevertheless.