stale icon indicating copy to clipboard operation
stale copied to clipboard

Add the ability to consider reactions

Open gorzelinski opened this issue 1 year ago • 7 comments

Description: As mentioned in https://github.com/actions/stale/issues/861#issuecomment-1695511627, in some projects it’s useful to track reactions as activity. This PR adds such an option (disabled by default). We tested it on our primary and supporting repositories, and it works as expected.

Related issue: https://github.com/actions/stale/issues/861

Check list:

  • [x] Mark if documentation changes are required.
  • [x] Mark if tests were added or updated to cover the changes.

gorzelinski avatar Sep 04 '23 08:09 gorzelinski

Hello @gorzelinski , we started to review the PR, but can you please meanwhile fix the failed checks of the PR?

dsame avatar Sep 06 '23 08:09 dsame

Hey @dsame, sure, I'll look into it ASAP.

gorzelinski avatar Sep 06 '23 08:09 gorzelinski

Should I do something more? As I see, the checks are passing now.

gorzelinski avatar Sep 27 '23 10:09 gorzelinski

cc: @gorzelinski thanks for contributing this!

cc: @marko-zivic-93 @MaksimZhukov @dusan-trickovic friendly ping. Please review when you folks get a chance. This will help a lot more issues stay active that are being reacted to. Thank you for maintaining this action for us!

nitrocode avatar Oct 06 '23 15:10 nitrocode

Hey @nitrocode, do we need additional reviews? Sorry for bothering you, but avoiding merge conflicts would be great.

gorzelinski avatar Nov 03 '23 09:11 gorzelinski

Hi @gorzelinski , I do not manage this repo. I was just trying to get this reviewed so we can eventually get it merged.

I can see from past merges that each merge seemed to require at least 2 approvals before merging

https://github.com/actions/stale/pulls?q=is%3Apr+is%3Amerged+-author%3Aapp%2Fdependabot+

nitrocode avatar Nov 04 '23 23:11 nitrocode

@nitrocode Oh, I didn't know. Thanks for the info anyway. So maybe I'll forward it to @dsame.

gorzelinski avatar Nov 07 '23 14:11 gorzelinski