setup-python icon indicating copy to clipboard operation
setup-python copied to clipboard

Throwing an error in getManifestFromRepo when the github API rate limiting response is a JSON object.

Open Lavaerius opened this issue 1 year ago • 3 comments

Description:

Updates fail condition for getManifestFromRepo function to include instances when github responds with JSON body for API rate limiting, that is incorrectly handled. Related issue:

https://github.com/actions/setup-python/issues/903

Check list:

  • [ ] Mark if documentation changes are required.
  • [ ] Mark if tests were added or updated to cover the changes.

Lavaerius avatar Sep 17 '24 19:09 Lavaerius

Hello @Lavaerius,

Are you planning to make modifications to this PR as per @konradpabjan's suggestion? Please update your input so that we can move this forward and resolve the issue.

Thank you!

mahabaleshwars avatar Sep 24 '24 04:09 mahabaleshwars

Yes, I'll look into that.

Lavaerius avatar Sep 24 '24 12:09 Lavaerius

I've submitted: https://github.com/actions/toolkit/pull/1832

Lavaerius avatar Sep 25 '24 02:09 Lavaerius