setup-python icon indicating copy to clipboard operation
setup-python copied to clipboard

Skip the post run step entirely if the cache is disabled

Open edmorley opened this issue 1 year ago • 3 comments

Description: Previously if cache: false (the default for this Action), the Action's "post run" step would still be executed.

Whilst this step was fast (since it returned early if the cache was disabled), it still causes unnecessary noise in the job's steps list.

For example as seen in: https://github.com/pypa/get-pip/actions/runs/8679713478/job/23798960684

Screenshot of post run step noise

Now, the post run step is skipped if the cache is disabled, thanks to the post-if syntax supporting the github.events.inputs.* context.

See: https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runspost-if https://github.com/actions/cache/blob/0c45773b623bea8c8e75f6c82b208c3cf94ea4f9/action.yml#L40

Related issue: N/A

Check list:

  • [ ] Mark if documentation changes are required.
  • [ ] Mark if tests were added or updated to cover the changes.

edmorley avatar Apr 14 '24 12:04 edmorley

@priya-kinthali Hi! Please could I have a review?

edmorley avatar Jul 08 '24 08:07 edmorley

Hello @edmorley, Thank you for creating this PR, we will review this PR and get back to you once we have some feedback on this.

aparnajyothi-y avatar Jul 23 '24 11:07 aparnajyothi-y