setup-python icon indicating copy to clipboard operation
setup-python copied to clipboard

Respect username on macOS self-hosted runners

Open fkorotkov opened this issue 2 years ago • 7 comments

Description:

Right now it's hardcoded to "runner". I'm not sure why it's hardcoded on macOS in the first place. I tried to dig some history in #466 made by @techman83 but have not spent enough time to get to the root cause.

Check list:

  • [ ] Mark if documentation changes are required.
  • [ ] Mark if tests were added or updated to cover the changes.

fkorotkov avatar Jul 25 '23 21:07 fkorotkov

IIRC I didn't change the mac path, because this related to how actions/setup-python compiles (at least compiled when I submitted my PR) the python libraries. Covered by the commit comment:

Shared libraries for the Mac python builds are not configured with the relocatable flag, thus must always be configured with the hosted path.

It'll be worth referencing where this was fixed upstream, but there was definitely a reason :slightly_smiling_face:

techman83 avatar Jul 27 '23 07:07 techman83

Hello @fkorotkov. Could you please run the npm run format && npm run build command ?

dmitry-shibanov avatar Jul 31 '23 10:07 dmitry-shibanov

@dmitry-shibanov my bad! I only ran npm run build. Formatted code in 2750121 and npm run builded just in case but nothing changed.

fkorotkov avatar Aug 01 '23 16:08 fkorotkov

Hi Is there an update on this? Would be great to get this working :)

jonluca avatar Oct 26 '23 19:10 jonluca

Any update on merging this?

We use self hosted MacOS runners and are unable to upgrade to python-setup v5

kvasilye avatar Mar 26 '24 19:03 kvasilye

Hi. When are you going to merge this? I have same issue right now. Thanks!!

oscarbetancurj avatar Apr 16 '24 16:04 oscarbetancurj

Hello @fkorotkov 👋, Thank you for your contribution! We have reviewed this PR and encountered an error when testing it on a self-hosted runner with Python versions below 3.11. It appears that the changes are not compatible with these earlier versions. The error is as follows: Reason: tried: '/Users/runner/hostedtoolcache/Python/3.10.11/x64/lib/libpython3.10.dylib' (no such file) You can view the detailed logs here. Could you please take a look? Thanks in advance!

priya-kinthali avatar Aug 27 '24 04:08 priya-kinthali