setup-node icon indicating copy to clipboard operation
setup-node copied to clipboard

Make eslint-compact matcher compatible with Stylelint

Open FloEdelmann opened this issue 6 years ago • 5 comments

Stylelint has a compact formatter that is (nearly) compatible with ESLint one's.

It outputs lowercase severity strings though, so eslint-compact matcher's RegExp is not triggered.

This PR changes the matcher to also match lowercase severity strings.

Alternatively, the matcher could be duplicated as stylelint-compact and both RegExps could target exact lowercase/uppercase severities.


Example check run containing Stylelint output: https://github.com/OpenLightingProject/open-fixture-library/pull/1163/checks?check_run_id=365592295

FloEdelmann avatar Dec 27 '19 23:12 FloEdelmann

I really want this update! 🙏

ybiquitous avatar Apr 10 '20 07:04 ybiquitous

any interest in updating PR to target main instead of master?

bryanmacfarlane avatar Jan 20 '21 17:01 bryanmacfarlane

@bryanmacfarlane Done :ok_hand:

FloEdelmann avatar Jan 20 '21 19:01 FloEdelmann

Stylelint has a compact formatter that is (nearly) compatible with ESLint one's.

It outputs lowercase severity strings though, so eslint-compact matcher's RegExp is not triggered.

This PR changes the matcher to also match lowercase severity strings.

Alternatively, the matcher could be duplicated as stylelint-compact and both RegExps could target exact lowercase/uppercase severities.

Example check run containing Stylelint output: https://github.com/OpenLightingProject/open-fixture-library/pull/1163/checks?check_run_id=365592295

Jimimaku avatar Nov 21 '22 22:11 Jimimaku

Friendly ping 🏓

szepeviktor avatar Feb 29 '24 12:02 szepeviktor