setup-node icon indicating copy to clipboard operation
setup-node copied to clipboard

fix: remove hardcoded bearer

Open marco-ippolito opened this issue 1 month ago • 0 comments

Followup of https://github.com/actions/setup-node/pull/1240

Description: This change makes the mirror usable. Right now Immagine we setup the value of mirror-token to foo. In this line the value is used as https://github.com/actions/setup-node/blob/2951748f4c016b747952f8ca7e75fc64f2f62b53/src/distributions/base-distribution.ts#L106

Bearer foo but in other places such as: https://github.com/actions/setup-node/blob/2951748f4c016b747952f8ca7e75fc64f2f62b53/src/distributions/base-distribution.ts#L149

https://github.com/actions/setup-node/blob/2951748f4c016b747952f8ca7e75fc64f2f62b53/src/distributions/base-distribution.ts#L210

its used as is.

But if we change the value to Bearer foo, https://github.com/actions/setup-node/blob/2951748f4c016b747952f8ca7e75fc64f2f62b53/src/distributions/base-distribution.ts#L106 here it becomes Bearer Bearer foo which is incorrect, but works everywhere else.

So this PR makes it that if its a Bearer, the user needs to be explicit.

Related issue: Add link to the related issue.

Check list:

  • [ ] Mark if documentation changes are required.
  • [ ] Mark if tests were added or updated to cover the changes.

marco-ippolito avatar Jan 14 '26 16:01 marco-ippolito