setup-node icon indicating copy to clipboard operation
setup-node copied to clipboard

Replace uuid with crypto.randomUUID()

Open trivikr opened this issue 5 months ago • 4 comments

Description:

  • Replaces uuid with crypto.randomUUID()
  • Similar to https://www.github.com/actions/toolkit/pull/1824

Related issue: Fixes: https://github.com/actions/setup-node/issues/1377

Check list:

  • [ ] Mark if documentation changes are required.
  • [ ] Mark if tests were added or updated to cover the changes.

trivikr avatar Sep 24 '25 00:09 trivikr

Hi @trivikr, thank you for submitting the PR. Could you please resolve the check failures and run licensed status and npm run build commands to fix the failing checks related to licensed and dist.

gowridurgad avatar Oct 08 '25 09:10 gowridurgad

run licensed status

Done

$ licensed status   
Checking cached dependency records for setup-node
......................................................................................F.....
Errors:
* setup-node.npm.uuid
  version: 8.3.2, filename: /Users/trivikram/workspace/setup-node/.licenses/npm/uuid.dep.yml, license: , allowed: false
    - cached dependency record not found


92 dependencies checked, 1 errors found.

Licensed found errors during source enumeration.  Please see https://github.com/github/licensed/tree/master/docs/commands/status.md#status-errors-and-resolutions for possible resolutions.

$ licensed cache 
Caching dependency records for setup-node
  npm
    Using @actions/cache (4.0.3)
    Using @actions/core (1.11.1)
...
    Using xml2js (0.5.0)
    Using xmlbuilder (11.0.1)
  * 92 npm dependencies

Commit ee2d148 (#1378)

trivikr avatar Oct 08 '25 15:10 trivikr

The files in dist folders were updated in 7944727 (#1378)

trivikr avatar Oct 08 '25 15:10 trivikr

The issue in yarn 1 cache test seems to be with availability

error Error: https://registry.yarnpkg.com/istanbul-reports/-/istanbul-reports-3.2.0.tgz: Request failed "502 Bad Gateway"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
    at ResponseError.ExtendableBuiltin (/Users/runner/.yarn/lib/cli.js:696:66)
    at new ResponseError (/Users/runner/.yarn/lib/cli.js:802:124)

https://github.com/actions/setup-node/actions/runs/18350090223/job/52267623041

I believe CI should be successful, once it's approved to run by one of the maintainers.

trivikr avatar Oct 08 '25 16:10 trivikr

Hi @trivikr, There are merge conflicts in this PR. Could you please resolve them so we can proceed further?

gowridurgad avatar Jan 29 '26 09:01 gowridurgad

Could you please resolve them so we can proceed further?

Done.

trivikr avatar Jan 31 '26 17:01 trivikr