actions
feat: support private mirrors
Fixes: https://github.com/actions/setup-node/issues/1150 Fixes: https://github.com/actions/setup-node/issues/730
Hello @marco-ippolito, Thank you for your pull request! We are currently reviewing it. To resolve the check failures, could you please rebase your branch with the main branch and push the changes.
Hello marco-ippolito,
The fallback log message could be clarified to reduce potential confusion between falling back directly from Node and falling back to downloading from the Node mirror URL. Currently, it states: "Falling back to download directly from Node" for both scenarios.
A slight adjustment could provide clearer context in the logs. Please feel free to reach out if you have any concerns.
@aparnajyothi-y change the message to Not found in manifest. Falling back to download directly from 'your-mirror'
Hello @marco-ippolito, With the latest commit, the log message now correctly displays the mirror URL when provided, which is the expected behavior. However, in the default fallback scenario (when no mirror URL is provided), the log message currently shows: "Falling back to download directly from." Instead, it should remain as it was previously, showing: "Falling back to download directly from Node."
This log message should remain unchanged for the default fallback behavior.
Please feel free to reach out if you need further clarification or have any concerns.
Hello @marco-ippolito, With the latest commit, the log message still showing: "Falling back to download directly from" Instead, it should remain as it was previously, showing: "Falling back to download directly from Node"
This log message should remain unchanged for the default fallback behavior.
Please feel free to reach out if you need further clarification or have any concerns.