actions
Read version from use-node-version key of .npmrc
Description:
Add support for determining the Node version from the use-node-version key of .npmrc as described in the PNPM docs.
Related issue: Resolves #1130
Check list:
- [ ] Mark if documentation changes are required.
- [x] Mark if tests were added or updated to cover the changes.
We would love to be able to drop nvm entirely and this would be a huge help!
@aparnajyothi-y, bumping this again :) I'd love to get this in if my changes look good to you
@aparnajyothi-y, seems like you're quite busy. Is there someone else I should be seeking a review from?
I'd love to see this too! @aparnajyothi-y or @priya-kinthali, any chance we can nudge you to review this PR?
@aparnajyothi-y or @priya-kinthali, any chance we can nudge you to review this PR? If not, can you suggest another reviewer with bandwidth?
Hi @aparnajyothi-y or @priya-kinthali, could I trouble you to review this PR? I'd greatly appreciate it!
Hello Everyone, Thank you for this pull request. We are looking into it and get back to you once we have some feedback on this :)
seems like the below comments are why maintainers are staying away from approving this pr. i can take another crack in another pr if you don't have time
@mcevoypeter - I forked your PR to confirm what @PeterCardenas commented. Change to the lock file and dist directory are much more reasonable: https://github.com/actions/setup-node/pull/1253/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519. All I did was restore the lockfile, add @types/init and rebuild. Feel free to cherry pick the last commit.
Hello Everyone, Thank you for this pull request. We are looking into it and get back to you once we have some feedback on this :)
hi @aparnajyothi-y, I had a little time today so I went ahead and fixed up a few of the issue with this PR and created: https://github.com/actions/setup-node/pull/1253. Please take a look when you have a chance!