setup-java icon indicating copy to clipboard operation
setup-java copied to clipboard

feat: Add support for `.sdkmanrc` file in `java-version-file` parameter

Open guicamest opened this issue 11 months ago • 1 comments

Description: Add support for .sdkmanrc file in java-version-file parameter, as well as tests and updated documentation related to the new feature.

I've renamed one e2e test (setup-java-version-from-file-major-minor-patch-with-dist) to include the actual name of the file under test. Without it, there were many job runs with the same name (i.e. ${{ matrix.distribution }} version from file 'openjdk64-17.0.10' - ${{ matrix.os }}), making it quite difficult to find the appropriate ones to verify - and losing a key element of the test: the name of the java-version-file.

Related issue: #669

Check list:

  • [ ] Mark if documentation changes are required.
  • [x] Mark if tests were added or updated to cover the changes.

guicamest avatar Jan 25 '25 23:01 guicamest

@aparnajyothi-y @HarithaVattikuti sorry for the direct ping. Would it be possible for the team to take a look at the PR or at least provide some feedback any time soon?

guicamest avatar Jan 29 '25 09:01 guicamest

Thank you, @guicamest, for your work on this feature and for the detailed documentation and test updates!

I noticed that the branch currently has conflicts with src/util.ts, which need to be resolved before we can proceed with the merge. Let me know if you need any assistance in resolving these conflicts.

Please also ensure that all relevant documentation and test coverage boxes are checked, as per the checklist.

mahabaleshwars avatar Nov 04 '25 02:11 mahabaleshwars

Thank you, @guicamest, for your work on this feature and for the detailed documentation and test updates!

I noticed that the branch currently has conflicts with src/util.ts, which need to be resolved before we can proceed with the merge. Let me know if you need any assistance in resolving these conflicts.

Please also ensure that all relevant documentation and test coverage boxes are checked, as per the checklist.

Thanks for taking a look @mahabaleshwars :) I've solved the conflicts 👍

guicamest avatar Nov 04 '25 11:11 guicamest