setup-java icon indicating copy to clipboard operation
setup-java copied to clipboard

Support Tencent Kona JDK

Open johnshajiang opened this issue 1 year ago • 5 comments

Description: Tencent is one of main OpenJDK contributors, and it has its own OpenJDK distro, exactly Tencent Kona JDK. We'd like to see setup-java support this distro as well.

Justification: GitHub Java projects can easily apply Tencent Kona JDK with GitHub Actions.

Are you willing to submit a PR? Sure

johnshajiang avatar Aug 14 '24 03:08 johnshajiang

Hi @johnshajiang 👋, Thank you for the feature request. We'll investigate it and get back to you as soon as we have updates.

priyagupta108 avatar Aug 14 '24 05:08 priyagupta108

Thanks for triaging this issue!

I already submitted the PR #672 for this feature, please take a look at it as well.

johnshajiang avatar Aug 14 '24 06:08 johnshajiang

I just updated the commit in PR #672 for supporting Kona JDK 21 and resolving the file conflicts. Please review this PR. Please feel free to raise your concerns.

johnshajiang avatar Sep 12 '24 07:09 johnshajiang

The commit in PR #672 just was updated again. I really appreciate this PR could be reviewed. Our and maybe others' Java projects on GitHub would like to use Tencent Kona JDK releases for testing with GitHub Actions.

A bit additional information: Gradle and SDKMAN already support Tencent Kona JDK. Please see the below links: https://docs.gradle.org/current/userguide/toolchains.html

https://sdkman.io/jdks/

johnshajiang avatar Oct 10 '24 09:10 johnshajiang

+1 for Tencent Kona JDK

liangyuanpeng avatar Jan 23 '25 02:01 liangyuanpeng