setup-java icon indicating copy to clipboard operation
setup-java copied to clipboard

Published 20 hours ago • verified publisher icon actions

Fix the bug about parsing dragonwell version (#642)

Open Accelerator1996 opened this issue 1 year ago • 14 comments

Description: Fix the bug about parsing dragonwell version

Related issue: #642

Check list:

  • [ ] Mark if documentation changes are required.
  • [x] Mark if tests were added or updated to cover the changes.

Accelerator1996 avatar Jul 01 '24 09:07 Accelerator1996

@IvanZosimov Hello, all tests passed. Please review this pull request. Thank you very much

Accelerator1996 avatar Jul 01 '24 09:07 Accelerator1996

@IvanZosimov Hello, all tests passed. Please review this pull request. Thank you very much

@IvanZosimov Hello, please review this pull request. Thank you very much!

Accelerator1996 avatar Jul 08 '24 02:07 Accelerator1996

is there a way to mark this project as abandonware?

esaulpaugh avatar Jul 11 '24 05:07 esaulpaugh

is there a way to mark this project as abandonware?

Why is it listed as abandoned software?

Accelerator1996 avatar Jul 12 '24 02:07 Accelerator1996

Description: Fix the bug about parsing dragonwell version Related issue: #642 Check list:

  • [ ] > - [ ] Mark if documentation changes are required.
  • [ ] > - [ ] Mark if tests were added or updated to cover the changes. a3c03fb

Hello, I think this does not need to be changed according to the original content in the usage document

Accelerator1996 avatar Jul 18 '24 09:07 Accelerator1996

Description: Fix the bug about parsing dragonwell version Related issue: #642 Check list:

  • [ ] > - [ ] Mark if documentation changes are required.
  • [ ] > - [ ] Mark if tests were added or updated to cover the changes.

Sorry, I have added the test case and updated test data. The original test case is indeed a bit insufficient. Please review, thank you very much!

Accelerator1996 avatar Jul 19 '24 02:07 Accelerator1996