setup-java icon indicating copy to clipboard operation
setup-java copied to clipboard

The resulting JAVA_HOME_..._architecture variable name is inconsistent: ARM64 or AARCH64

Open vlsi opened this issue 2 years ago • 1 comments

Description:

The environment variable name is inconsistent: sometimes it is JAVA_HOME_17_AARCH64 and sometimes it is JAVA_HOME_17_ARM64.

https://github.com/actions/setup-java/blob/9eda6b51cc4f6ee99be3dd5537b85e389e47bda9/src/distributions/base-installer.ts#L172

Task version:

'actions/setup-java@v3' (SHA:0ab4596768b603586c0de567f2430c30f5b0d2b0)

Platform:

  • [x] Ubuntu
  • [ ] macOS
  • [ ] Windows

Runner type:

  • [x] Hosted
  • [x] Self-hosted

Repro steps:
A description with steps to reproduce the issue. If your have a public example or repo to share, please provide the link.

Expected behavior:

The variable name should be consistent. Preferably, the variable name should use the same values as the action's architecture input parameter: https://github.com/actions/setup-java/blob/9eda6b51cc4f6ee99be3dd5537b85e389e47bda9/README.md#L36

Actual behavior:

If user omits architecture, then setup-java generates JAVA_HOME_17_ARM64 environment variable. If user passes architecture: aarch64, then setup-java generates JAVA_HOME_17_AARCH64 variable.

vlsi avatar Nov 27 '23 14:11 vlsi

Hello @vlsi Thank you for filing your issue. We will investigate it and come back to you as soon as we have some information.

marko-zivic-93 avatar Nov 27 '23 15:11 marko-zivic-93