setup-java icon indicating copy to clipboard operation
setup-java copied to clipboard

Check-latest is false, but still tries to resolve latest version. Then fails and just passes without setting up the requested version

Open kalmanbencze opened this issue 2 years ago • 8 comments

Description: image We use v3 of the action and use it to set up adopt jdk 17. It's causing a lot of headaches that it's trying to resolve latest version, it times out and just completes without failing. There's other times where it's actually failing: image

Task version: v3

Platform:

  • [X] Ubuntu
  • [ ] macOS
  • [ ] Windows

Runner type:

  • [X] Hosted
  • [ ] Self-hosted

Repro steps:
Start a matrix of 40-50 jobs all setting up java with: - name: Set up JDK 17 uses: actions/setup-java@v3 with: distribution: 'adopt' java-version: '17' cache: 'gradle' It's guaranteed to happen to at least 5-6 times.

Expected behavior: It's expected to set up java 17 from cache if check-latest: false is specified and not fail on "checking latest version" when it still needs to download it.

Actual behavior: check-latest: false is ignored as seen in screenshot #1, and when a very frequent timeout happens, the acton passes successfully.

kalmanbencze avatar Jul 28 '23 12:07 kalmanbencze

upgrading to 3.12.0 may have fixed the issue, I'll close this if it doesn't reproduce anymore.

Edit: I upgraded to 3.12.0 and specified 17.0.8+7 as java version but the issue still happens.

kalmanbencze avatar Jul 28 '23 13:07 kalmanbencze

Hi, @kalmanbencze 👋 Thanks for the issue, we will take a look!

IvanZosimov avatar Jul 28 '23 13:07 IvanZosimov

Hi, @kalmanbencze 👋 I tried to reproduce the issue, but unfortunately without luck. May I ask you to turn the debug mode on (link to guide how to do this can be found here) and provide us with additional information about the failed runs (links or logs would be appreciated).

IvanZosimov avatar Aug 23 '23 12:08 IvanZosimov

Just a gentle ping, @kalmanbencze 📟

IvanZosimov avatar Sep 01 '23 08:09 IvanZosimov

sorry I was afk for a bit, will do and report back.

kalmanbencze avatar Sep 05 '23 12:09 kalmanbencze

I had reproduced it with extra logs (I hope): image logs_136801.zip the step is stuck at downloading jdk at 99.4% forever.

kalmanbencze avatar Sep 06 '23 15:09 kalmanbencze

24_build (featurefamilyrewardsfamilyrewards-implementation).txt maybe I haven't enabled the debug logging properly? I did what the guide said about adding the secret ACTIONS_RUNNER_DEBUG with true image

kalmanbencze avatar Sep 06 '23 15:09 kalmanbencze