setup-go icon indicating copy to clipboard operation
setup-go copied to clipboard

Problem matchers: Matches of test failures

Open WillAbides opened this issue 2 years ago • 2 comments

Description:

Currently test failures do not get annotated because the problem matcher requires that a column number be present, but go's test output does not include a column for test failures.

An example line that gets missed by the current matcher is:

/path/to/main_test.go:13: expected true but got false

The updated matcher makes the column number optional and matches the line above.

Check list:

  • [ ] Mark if documentation changes are required.
  • [x] Mark if tests were added or updated to cover the changes.

WillAbides avatar Sep 13 '23 18:09 WillAbides

Hello @WillAbides , we are starting to review the PR

dsame avatar Sep 18 '23 06:09 dsame

You might want to hold off on this one for a bit. I used this same strategy in another action and got this report about it.

This pattern also matches test log statements, so those are getting annotated as failures even when the test passes.

WillAbides avatar Sep 22 '23 14:09 WillAbides