setup-go
setup-go copied to clipboard
feat: Utilize the`.tool-versions` file to set expected Go version
Description:
It would be useful to utilize the .tool-versions file to set the expect version of Go for the action runtime in addition to being able to set via the parameters.
Justification:
Because an action may be used across a variety of steps, it can be burdensome to track the Go version via the parameter in every place used. Several other setup-<lang> projects are also utilizing or making progress towards using the .tool-versions file for version locking.
- Ruby currently utilizes
- Python has a PR open to add this functionality
- Node uses it
Are you willing to submit a PR? 💯 if this feels like a thing that would be useful to the community and in keeping with the goal of this project.
Hi, @plukevdh 👋 Thanks for the feature request, we will take a look and get back to you with updates.
@IvanZosimov thanks! Note that I also opened a PR for this feature as well with some initial ideas: https://github.com/actions/setup-go/pull/376
This would be awesome to have, the setup-node action also supports this 👍
- uses: actions/setup-node@v3 with: # ... # File containing the version Spec of the version to use. Examples: .nvmrc, .node-version, .tool-versions. # If node-version and node-version-file are both provided the action will use version from node-version. node-version-file: ''https://github.com/actions/setup-node#usage
Hello @plukevdh , thank you for your contribution, but i would ask you to review this PR as well https://github.com/actions/setup-go/pull/402 - do you see any drawbacks of using the existing go-version-file input instead of introducing new one tool-versions-file https://github.com/actions/setup-go/pull/376/files#diff-b97cd7a3fa566070832c220ba3fab8e4f60694550f6fe74d6024a20486165de8R148 ?
@dsame Happy to close this in favor of #402 since it's a simpler solve.
Hello @plukevdh , thank you for assistance to make a choice between #402 and #376, but i'll keep this issue open till #402 will have been merged