runner icon indicating copy to clipboard operation
runner copied to clipboard

"`pre` execution is not supported for local action from '{repoAction.Path}'" should correctly specify which action is triggering it

Open jsoref opened this issue 1 year ago • 0 comments

https://github.com/actions/runner/blob/2a7f327d93fb79326c974f4858ce62c3b81c580a/src/Runner.Worker/ActionRunner.cs#L108

https://github.com/check-spelling-sandbox/playwright/actions/runs/10011307718

ubuntu-22.04 (chromium - Node.js 22)pre execution is not supported for local action from './.github/actions/run-test'   ubuntu-22.04 (chromium - Node.js 22) pre execution is not supported for local action from './.github/actions/run-test'

This is the workflow: https://github.com/microsoft/playwright/blob/b8546eb35ea23c735be656b5675988cbc5486c7b/.github/workflows/tests_primary.yml

And This is the blamed file and if you search for pre: you will not find it: https://github.com/microsoft/playwright/blob/185cc43dbf8dee8f31e10205c136c66dc4efb6a0/.github/actions/run-test/action.yml

The cause is in fact: https://github.com/microsoft/playwright/blob/185cc43dbf8dee8f31e10205c136c66dc4efb6a0/.github/actions/run-test/action.yml#L75

Which pulls in: https://github.com/Azure/login/blob/e1a0ade0c10e6fce656e01e74e6ca3c5054a0907/action.yml#L42

Which was added by: https://github.com/Azure/login/pull/384

But 99% of playwright users won't know to blame Azure login for it because the message reported by actions/runner doesn't finger Azure/login.

Note that I was lucky, the workflow had one composite action which in turn only had four uses: lines, one of which was yet another composite action, but thankfully that didn't itself use any additional actions.

Composite actions can pull in other actions to a depth of around 6 iirc and there can easily be 6 uses: lines. It could have been much worse.

Asks:

  1. Provide a full chain to the action pre:
  2. Include line numbers for each thing in the chain

jsoref avatar Jul 19 '24 18:07 jsoref