runner icon indicating copy to clipboard operation
runner copied to clipboard

Support timeout-minutes in composite-actions

Open Flydiverny opened this issue 2 years ago • 12 comments

Describe the enhancement We would like to see timeout-minutes supported on steps in composite actions

Code Snippet If applicable, add a code snippet.

name: terraform-cache

inputs:
  working-directory:
    description: Directory to run terraform in
    required: false
    default: ""

runs:
  using: composite
  steps:
    - name: Cache Terraform
      uses: actions/cache@v3
      timeout-minutes: 2
      with:
        path: ${{ runner.temp }}/.terraform.d/plugin-cache
        key: ${{ runner.os }}-terraform-${{ inputs.working-directory }}-${{ hashFiles('**/.terraform.lock.hcl') }}
        restore-keys: |
          ${{ runner.os }}-terraform-${{ inputs.working-directory }}-
          ${{ runner.os }}-terraform-

Additional information Occasionally actions like actions/cache bug out (see https://github.com/actions/cache/issues/810 etc) and run for the default timeout time (6 hours) which causes unnecessary costs and extra work as CI will be left running and needs to be aborted and re-run. With the possibility to set timeout-minutes on steps in composite actions this damage could be limited and have actions finish in a timely manner even if the cache action fails.

I see from previous ADRs 0549 and 1144 that timeout-minutes are to be considered in the future and last mention it was waited with due to little buzz about this feature missing, so heres some buzz 🐝 🙂


NOTE: if the feature request has been agreed upon then the assignee will create an ADR. See docs/adrs/README.md

Flydiverny avatar Jun 29 '22 10:06 Flydiverny

👋 +1

ghost avatar Jun 29 '22 10:06 ghost

+1000 behalf of all of our Developers and Automation Engineers who need this badly !

PavanMudigondaTR avatar Sep 08 '22 23:09 PavanMudigondaTR

+1111

vctqs1 avatar Oct 27 '22 03:10 vctqs1

+2222

phungtruongnguyen94 avatar Oct 27 '22 03:10 phungtruongnguyen94

Just recently came across this limitation. I hope it will be implemented swiftly.

Recurse-blip avatar Jan 04 '23 17:01 Recurse-blip

+1

fl250144 avatar Jan 10 '23 17:01 fl250144

It's weird not to have this option. And at the very least it should have been documented

malfet avatar Jan 23 '23 02:01 malfet

+1

jmdelaney8 avatar Jan 24 '23 21:01 jmdelaney8

please stop commenting +1, many of us are subscribed to receive updates on this issue

  • if you want to see it happen, click the +1 react on the original issue
  • if you want to be notified about changes to this issue click the [subscribe] button on the right
  • but please please stop commenting +1, some of us are interested in updates to this and not comment spam

asottile-sentry avatar Jan 24 '23 21:01 asottile-sentry

This issue is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 15 days.

github-actions[bot] avatar Feb 12 '24 00:02 github-actions[bot]

not stale, still wanted, hire more people

nikaro avatar Feb 12 '24 00:02 nikaro

Dear GitHub, kind ask to introduce this option into composite actions

moarpheus avatar Apr 11 '24 10:04 moarpheus