runner-images icon indicating copy to clipboard operation
runner-images copied to clipboard

Issues #11016 not fixed. windows-2022 version 20241113.3.0 and 20241201.2.0 fail with the same error

Open mihnita opened this issue 1 year ago • 4 comments

Description

Same as before.

I can copy-paste the description here, but I think the older bug has more context: https://github.com/actions/runner-images/issues/11016

Unfortunately it looks like I am not allowed to reopen that one.

Platforms affected

  • [ ] Azure DevOps
  • [X] GitHub Actions - Standard Runners
  • [ ] GitHub Actions - Larger Runners

Runner images affected

  • [ ] Ubuntu 20.04
  • [ ] Ubuntu 22.04
  • [ ] Ubuntu 24.04
  • [ ] macOS 12
  • [ ] macOS 13
  • [ ] macOS 13 Arm64
  • [ ] macOS 14
  • [ ] macOS 14 Arm64
  • [ ] macOS 15
  • [ ] macOS 15 Arm64
  • [ ] Windows Server 2019
  • [X] Windows Server 2022

Image version and build link

Image: windows-2022

  • Version: 20241125.1.0: https://github.com/unicode-org/icu/actions/runs/12102218460/job/33821985059?pr=3288
  • Version 20241201.2.0: https://github.com/unicode-org/icu/actions/runs/12102218460/job/34159144276

Is it regression?

20241021.1.0, https://github.com/unicode-org/icu/actions/runs/11937265609/job/33272850958

Expected behavior

Not fail.

Actual behavior

See https://github.com/actions/runner-images/issues/11016

Repro steps

See https://github.com/actions/runner-images/issues/11016

mihnita avatar Dec 09 '24 22:12 mihnita

Hi @mihnita ,

Thank you for bringing this issue to our attention. We are looking into this issue and will update you on this issue after investigating

kishorekumar-anchala avatar Dec 10 '24 05:12 kishorekumar-anchala

Hi @mihnita The new image has been rolled out with the latest version 20241211.1 . Can you please try now.Thanks.

RaviAkshintala avatar Dec 16 '24 09:12 RaviAkshintala

Thank you, but it still does not seem to be fixed. See https://github.com/unicode-org/icu/actions/runs/12102218460/job/34544963869

Runner Image
  Image: windows-2022
  Version: 20241211.1.0
  Included Software: https://github.com/actions/runner-images/blob/win22/20241211.1/images/windows/Windows2022-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/win22%2F20241211.1

With the same error (The expression "[MSBuild]::VersionGreaterThanOrEquals('', 9.0)" cannot be evaluated):

"D:\a\icu\icu\icu4c\source\allinone\allinone.sln" (default target) (1) ->
"D:\a\icu\icu\icu4c\source\data\makedata_uwp.vcxproj" (default target) (56) ->
  C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VisualStudio\v17.0\AppxPackage\Microsoft.AppXPackage.Targets(225,25): error MSB4184: The expression "[MSBuild]::VersionGreaterThanOrEquals('', 9.0)" cannot be evaluated. Version string was not in a correct format. [D:\a\icu\icu\icu4c\source\data\makedata_uwp.vcxproj]

    409 Warning(s)
    1 Error(s)

mihnita avatar Dec 17 '24 17:12 mihnita

Hi @mihnita Could you please try again with the Image version 20241215.1.0. I tested it locally, and it worked without any errors.Thanks.

Current runner version: '2.321.0'
Operating System
Runner Image
  Image: windows-2022
  Version: 20241215.1.0
  Included Software: https://github.com/actions/runner-images/blob/win22/20241215.1/images/windows/Windows2022-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/win22%2F20241215.1
 "D:\a\icu-\icu-\icu4c\source\allinone\allinone.sln" (default target) (1) ->
"D:\a\icu-\icu-\icu4c\source\tools\icuinfo\testplug.vcxproj.metaproj" (default target) (54) ->
"D:\a\icu-\icu-\icu4c\source\tools\icuinfo\testplug.vcxproj" (default target) (55) ->
(PrepareForBuild target) -> 
  C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(531,5): warning MSB8028: The intermediate directory (.\x64\Debug\) contains files shared from another project (icuinfo.vcxproj).  This can lead to incorrect clean and rebuild behavior. [D:\a\icu-\icu-\icu4c\source\tools\icuinfo\testplug.vcxproj]

    338 Warning(s)
    0 Error(s)


https://github.com/RaviAkshintala/icu-/actions/runs/12410150575/job/34645186030

RaviAkshintala avatar Dec 19 '24 10:12 RaviAkshintala

Hi @mihnita We have tried to reproduce the issue, but we are not encountering any errors. The details are provided here. We are closing this issue. Thank you.

RaviAkshintala avatar Dec 30 '24 11:12 RaviAkshintala

Thank you very kindly for trying this out @RaviAkshintala!

Hi @mihnita Could you please try again with the Image version 20241215.1.0. I tested it locally, and it worked without any errors.Thanks.

However, it looks like the branch that you build has the /p:SkipUWP=true flag set, meaning that it will completely avoid building the problematic projects. :(

From the log output: Run msbuild icu4c/source/allinone/allinone.sln /p:Configuration=Debug /p:Platform=x64 /p:SkipUWP=true

So I don't know if this issue is actually fixed. :(

jefgen avatar Jan 18 '25 00:01 jefgen