runner-images icon indicating copy to clipboard operation
runner-images copied to clipboard

Wrong Signature Thumbprint - Install Visual Studio - Windows Server 2022 Runner Image

Open Ami-007 opened this issue 1 year ago • 8 comments

Description

Install Visual Studio has the wrong signature thumbprint on the test.

==> azure-arm.build_vhd: Provisioning with powershell script: /agent/_work/1/s/runner-images/images/windows/scripts/build/Install-VisualStudio.ps1 azure-arm.build_vhd: Downloading Bootstrapper ... azure-arm.build_vhd: Downloading package from https://aka.ms/vs/17/release/vs_Enterprise.exe to C:\Users\INSTAL~1\AppData\Local\Temp\vs_Enterprise.exe... azure-arm.build_vhd: Package downloaded in 0.42 seconds azure-arm.build_vhd: Signature thumbprint do not match expected. azure-arm.build_vhd: At C:\Program Files\WindowsPowerShell\Modules\ImageHelpers\InstallHelpers.ps1:973 char:9 azure-arm.build_vhd: + throw "Signature thumbprint do not match expected." azure-arm.build_vhd: + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ azure-arm.build_vhd: + CategoryInfo : OperationStopped: (Signature thumb...match expected.:String) [], RuntimeException azure-arm.build_vhd: + FullyQualifiedErrorId : Signature thumbprint do not match expected. azure-arm.build_vhd:

Platforms affected

  • [X] Azure DevOps
  • [ ] GitHub Actions - Standard Runners
  • [ ] GitHub Actions - Larger Runners

Runner images affected

  • [ ] Ubuntu 20.04
  • [ ] Ubuntu 22.04
  • [ ] Ubuntu 24.04
  • [ ] macOS 12
  • [ ] macOS 13
  • [ ] macOS 13 Arm64
  • [ ] macOS 14
  • [ ] macOS 14 Arm64
  • [ ] Windows Server 2019
  • [X] Windows Server 2022

Image version and build link

N/A private build

Is it regression?

Yes - this worked on 19th August 2024

Expected behavior

All tests pass successfully and build completes successfully for Windows 2022 using the build code in runner images repo

Actual behavior

Our pipeline that builds the Windows 2022 image using the runner-images code from this repo is failing when attempting to install Visual Studio Enterprise and producing thumbprint error.

Repro steps

Run Packer build using the latest code in this repo for Windows Server 2022

Ami-007 avatar Sep 06 '24 11:09 Ami-007

@Ami-007 Thank you for bringing this issue to us. We are looking into this issue and will update you on this issue after investigating.

RaviAkshintala avatar Sep 06 '24 11:09 RaviAkshintala

I am also having this issue. I see this thumbprint mismatch issue frequently with this repository. Is there no way to have this automated in some way instead of doing manual fixes?

angaaruriakhil avatar Sep 06 '24 11:09 angaaruriakhil

Hi @cupacheeno , the new image has been rolled out (20240912.1.1) .The issue is fixed now. kindly synch your main .Thanks

vidyasagarnimmagaddi avatar Sep 16 '24 07:09 vidyasagarnimmagaddi

Hi @cupacheeno , the new image has been rolled out (20240912.1.1) .The issue is fixed now. kindly synch your main .Thanks

Where has 22 been fixed? I see a code update for 2019, but not for 2022. I have run a build and am still seeing the same error

Ami-007 avatar Sep 16 '24 10:09 Ami-007

Hi @Ami-007 , Please follow the official status page of Azure DevOps for updates https://status.dev.azure.com/_event/543117809

vidyasagarnimmagaddi avatar Sep 16 '24 10:09 vidyasagarnimmagaddi

Hi @Ami-007 , Please follow the official status page of Azure DevOps for updates https://status.dev.azure.com/_event/543117809

This issue has nothing to do with the self hosted agents.

I’m telling you that you haven’t updated the VS signature for Windows 2022 builds. Which incidentally, is what this issue is about.

Ami-007 avatar Sep 17 '24 08:09 Ami-007

@vidyasagarnimmagaddi can confirm in our instance the runners now work as expected

cupacheeno avatar Sep 17 '24 10:09 cupacheeno

Hi @Ami-007 , the visual studio signature thumbprint is already with the latest one, windows-2022 is successful. The thumbprint we are using is this F9A7CF9FBE13BAC767F4781061332DA6E8B4E0EE.Kindly check the same. thanks

vidyasagarnimmagaddi avatar Sep 17 '24 14:09 vidyasagarnimmagaddi

Hi @Ami-007 , the new image version 20240915.1 is rolled out. And we see no issue with visual studio signature thumbprint. Kindly synch your main . Closing the issue. Thanks.

vidyasagarnimmagaddi avatar Sep 19 '24 08:09 vidyasagarnimmagaddi

I still have the issue on 20241006.1.1 / Win2022 Please have another look at it

stoopman avatar Oct 16 '24 11:10 stoopman

I still have this issue on main (Windows2022) - and I did try "releases/win22/20241021" where I also have this issue!

hmayer1980 avatar Nov 19 '24 11:11 hmayer1980