runner-images icon indicating copy to clipboard operation
runner-images copied to clipboard

Update Android sdk Platform-Tools 35.0.2

Open yogurtearl opened this issue 1 year ago • 12 comments

Tool name

Android sdk Platform-Tools

Tool license

Android SDK license

Add or update?

  • [ ] Add
  • [X] Update

Desired version

35.0.2

Approximate size

No response

Brief description of tool

An older version of android "build tools" is already installed on the images, just need the current version of 35.0.2 installed.

URL for tool's homepage

https://developer.android.com/tools/releases/build-tools

Provide a basic test case to validate the tool's functionality.

Minimal Android build with android gradle plugin version 8.5.2

Platforms where you need the tool

  • [ ] Azure DevOps
  • [ ] GitHub Actions

Runner images where you need the tool

  • [ ] Ubuntu 20.04
  • [ ] Ubuntu 22.04
  • [ ] Ubuntu 24.04
  • [ ] macOS 12
  • [ ] macOS 13
  • [ ] macOS 13 Arm64
  • [ ] macOS 14
  • [ ] macOS 14 Arm64
  • [ ] Windows Server 2019
  • [ ] Windows Server 2022

Can this tool be installed during the build?

Yes, it will be downloaded if absent by the Android Gradle plugin.

Tool installation time in runtime

unknown

Are you willing to submit a PR?

possibly

yogurtearl avatar Aug 26 '24 16:08 yogurtearl

Hi @yogurtearl ,Thank you for bringing this issue to us. We are looking into this issue and will update you on this issue after investigating.

vidyasagarnimmagaddi avatar Aug 26 '24 17:08 vidyasagarnimmagaddi

Are you sure you don't mean "platform tools 35.0.2"? Looking at the available build tools, I see only up to 35.0.0 right now (30 Oct 2024).

With that being said, I am also running into related issues with Github Actions, which I'm investigating now. The build doesn't output anything for 19 minutes, and then:

(might be unrelated)

Warning: Errors during XML parse:
Warning: Additionally, the fallback loader failed to parse the XML.
Checking the license for package Android SDK Platform-Tools in /usr/local/lib/android/sdk/licenses
License for package Android SDK Platform-Tools accepted.
Preparing "Install Android SDK Platform-Tools v.35.0.2".

nokite avatar Oct 30 '24 10:10 nokite

ah, yup, updated.

yogurtearl avatar Nov 08 '24 16:11 yogurtearl

Hi @yogurtearl- Could you please confirm, whether you are referring to update "Android sdk build_tools 35.0.2" or "Android sdk Platform-Tools" because both tool versions are different.

Prabhatkumar59 avatar Nov 12 '24 15:11 Prabhatkumar59

I meant Android SDK Platform-Tools v.35.0.2

Sorry for the confusion.

yogurtearl avatar Nov 14 '24 14:11 yogurtearl

Hi @yogurtearl - Thanks for your input, could you please confirm from your side if Android SDK Platform-Tools is updated to v.35.0.2?

Prabhatkumar59 avatar Nov 21 '24 10:11 Prabhatkumar59

Hi @yogurtearl - We would like to inform you that the latest windows image version has been rolled out. Please update your sync process and try using the new version and please check for Android SDK Platform-Tools version. Thanks!

Prabhatkumar59 avatar Nov 28 '24 15:11 Prabhatkumar59

We don't use window runners, in this particular use case, we are using large linux runners.

Still seeing this in the logs, which indicates it wasn't pre-installed on the runner in the SDK:

2024-12-02T18:11:39.5015065Z Checking the license for package Android SDK Platform-Tools in /usr/local/lib/android/sdk/licenses
2024-12-02T18:11:39.5016249Z License for package Android SDK Platform-Tools accepted.
2024-12-02T18:11:39.5016921Z Preparing "Install Android SDK Platform-Tools v.35.0.2".
2024-12-02T18:11:40.1015352Z "Install Android SDK Platform-Tools v.35.0.2" ready.
2024-12-02T18:11:40.1016300Z Installing Android SDK Platform-Tools in /usr/local/lib/android/sdk/platform-tools
2024-12-02T18:11:40.1016981Z "Install Android SDK Platform-Tools v.35.0.2" complete.
2024-12-02T18:11:40.2015521Z "Install Android SDK Platform-Tools v.35.0.2" finished.

yogurtearl avatar Dec 02 '24 22:12 yogurtearl

if you run $ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager --list_installed you will get something like this:

Installed packages:
  Path                                                     | Version    | Description                                   | Location
  -------                                                  | -------    | -------                                       | -------
  build-tools;34.0.0                                       | 34.0.0     | Android SDK Build-Tools 34                    | build-tools/34.0.0
  build-tools;35.0.0                                       | 35.0.0     | Android SDK Build-Tools 35                    | build-tools/35.0.0
  emulator                                                 | 35.2.10    | Android Emulator                              | emulator
  patcher;v4                                               | 1          | SDK Patch Applier v4                          | patcher/v4
  platform-tools                                           | 35.0.2     | Android SDK Platform-Tools                    | platform-tools
  platforms;android-28                                     | 6          | Android SDK Platform 28                       | platforms/android-28
  platforms;android-35                                     | 1          | Android SDK Platform 35                       | platforms/android-35
  skiaparser;1                                             | 6          | Layout Inspector image server for API 29-30   | skiaparser/1
  skiaparser;2                                             | 3          | Layout Inspector image server for API S       | skiaparser/2
  skiaparser;3                                             | 5          | Layout Inspector image server for API 31-36   | skiaparser/3
  sources;android-30                                       | 1          | Sources for Android 30                        | sources/android-30
  sources;android-34                                       | 2          | Sources for Android 34                        | sources/android-34
  sources;android-35                                       | 1          | Sources for Android 35                        | sources/android-35
  system-images;android-31;default;arm64-v8a               | 4          | ARM 64 v8a System Image                       | system-images/android-31/default/arm64-v8a
  system-images;android-31;google_apis;arm64-v8a           | 11         | Google APIs ARM 64 v8a System Image           | system-images/android-31/google_apis/arm64-v8a
  system-images;android-31;google_apis_playstore;arm64-v8a | 9          | Google Play ARM 64 v8a System Image           | system-images/android-31/google_apis_playstore/arm64-v8a
  system-images;android-35;google_apis;arm64-v8a           | 8          | Google APIs ARM 64 v8a System Image           | system-images/android-35/google_apis/arm64-v8a

This shows you all the versions of the various Android SDK packages that are installed.

yogurtearl avatar Dec 02 '24 22:12 yogurtearl

Hi @yogurtearl - Thanks for your inputs. As I can observe from your above screenshots- Android SDK Platform tool is already ready with version 35.0.2 Show below in screenshots:- "2024-12-02T18:11:39.5016921Z Preparing "Install Android SDK Platform-Tools v.35.0.2". 2024-12-02T18:11:40.1015352Z "Install Android SDK Platform-Tools v.35.0.2" ready."

"platform-tools | 35.0.2 | Android SDK Platform-Tools | platform-tools"

So, Please confirm whether it is updated to Android sdk Platform-Tools 35.0.2. Thanks!

Prabhatkumar59 avatar Dec 04 '24 15:12 Prabhatkumar59

no, this is not fixed and not updated. :)

If you run $ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager --list_installed on the ubuntu-22.04 image version 2.321.0 you will get:

Installed packages:
  Path                               | Version       | Description                      | Location                          
  -------                            | -------       | -------                          | -------                           
  build-tools;31.0.0                 | 31.0.0        | Android SDK Build-Tools 31       | build-tools/31.0.0                
  build-tools;32.0.0                 | 32.0.0        | Android SDK Build-Tools 32       | build-tools/32.0.0                
  build-tools;33.0.0                 | 33.0.0        | Android SDK Build-Tools 33       | build-tools/33.0.0                
  build-tools;33.0.1                 | 33.0.1        | Android SDK Build-Tools 33.0.1   | build-tools/33.0.1                
  build-tools;33.0.2                 | 33.0.2        | Android SDK Build-Tools 33.0.2   | build-tools/33.0.2                
  build-tools;33.0.3                 | 33.0.3        | Android SDK Build-Tools 33.0.3   | build-tools/33.0.3                
  build-tools;34.0.0                 | 34.0.0        | Android SDK Build-Tools 34       | build-tools/34.0.0                
  build-tools;35.0.0                 | 35.0.0        | Android SDK Build-Tools 35       | build-tools/35.0.0                
  cmake;3.10.2.4988404               | 3.10.2        | CMake 3.10.2.4988404             | cmake/3.10.2.4988404              
  cmake;3.18.1                       | 3.18.1        | CMake 3.18.1                     | cmake/3.18.1                      
  cmake;3.22.1                       | 3.22.1        | CMake 3.22.1                     | cmake/3.22.1                      
  extras;android;m2repository        | 47.0.0        | Android Support Repository       | extras/android/m2repository       
  extras;google;google_play_services | 49            | Google Play services             | extras/google/google_play_services
  extras;google;m2repository         | 58            | Google Repository                | extras/google/m2repository        
  ndk;26.3.11579264                  | 26.3.11579264 | NDK (Side by side) 26.3.11579264 | ndk/26.3.11579264                 
  ndk;27.2.12479018                  | 27.2.12479018 | NDK (Side by side) 27.2.12479018 | ndk/27.2.12479018                 
  platforms;android-31               | 1             | Android SDK Platform 31          | platforms/android-31              
  platforms;android-32               | 1             | Android SDK Platform 32          | platforms/android-32              
  platforms;android-33               | 3             | Android SDK Platform 33          | platforms/android-33              
  platforms;android-33-ext4          | 1             | Android SDK Platform 33-ext4     | platforms/android-33-ext4         
  platforms;android-33-ext5          | 1             | Android SDK Platform 33-ext5     | platforms/android-33-ext5         
  platforms;android-34               | 3             | Android SDK Platform 34          | platforms/android-34              
  platforms;android-34-ext10         | 1             | Android SDK Platform 34-ext10    | platforms/android-34-ext10        
  platforms;android-34-ext11         | 1             | Android SDK Platform 34-ext11    | platforms/android-34-ext11        
  platforms;android-34-ext12         | 1             | Android SDK Platform 34-ext12    | platforms/android-34-ext12        
  platforms;android-34-ext8          | 1             | Android SDK Platform 34-ext8     | platforms/android-34-ext8         
  platforms;android-35               | 1             | Android SDK Platform 35          | platforms/android-35              
  platforms;android-35-ext14         | 1             | Android SDK Platform 35-ext14    | platforms/android-35-ext14        

When this is fixed you will see this line in the output:

 platform-tools                                           | 35.0.2     | Android SDK Platform-Tools                    | platform-tools

These lines below 👇 indicate it is NOT fixed, as this happens when AGP (Android Gradle Plugin) detect missing platform tools and re-downloads them on the fly. Every android build is having to redownload this every build.

2024-12-02T18:11:39.5016921Z Preparing "Install Android SDK Platform-Tools v.35.0.2".
2024-12-02T18:11:40.1015352Z "Install Android SDK Platform-Tools v.35.0.2" ready.

yogurtearl avatar Dec 04 '24 18:12 yogurtearl

Hi @yogurtearl - Thanks for your input. We will check on this and will update you.

Prabhatkumar59 avatar Dec 09 '24 12:12 Prabhatkumar59

Hi @yogurtearl - Could you please try to update and confirm whether it is updated to Android sdk Platform-Tools 35.0.2 as new image version has been rolled out. Thanks!

Prabhatkumar59 avatar Dec 21 '24 03:12 Prabhatkumar59

I get this: Warning: Failed to find package 'build-tools;35.0.2'

Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu20%2F20241117.1 I use azure devops, this issue suddenly starting happening 3 weeks ago, while changed nothing [AGENT_OS] --> [Linux]

avrim-tr avatar Dec 24 '24 20:12 avrim-tr

platform-tools is still not in the latest ubuntu images.

Tested with:

Image: ubuntu-22.04
  Version: 20241215.1.0
  Included Software: https://github.com/actions/runner-images/blob/ubuntu22/2024[12](https://github.com/resy/android/actions/runs/12572138002/job/35043785640#step:1:13)15.1/images/ubuntu/Ubuntu2204-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20241215.1

Looks like platform-tools was added to windows and macos images, but not ubuntu images:

https://github.com/search?q=repo%3Aactions%2Frunner-images%20platform-tools&type=code

yogurtearl avatar Jan 01 '25 16:01 yogurtearl

Hi @yogurtearl - Thanks for your input. We will check on this and will update you.

Prabhatkumar59 avatar Jan 06 '25 10:01 Prabhatkumar59

Thi is also relevant for ubuntu-24.04, not just ubuntu-22.04

MGaetan89 avatar Jan 17 '25 09:01 MGaetan89

Hi @yogurtearl - Thanks for your inputs. Could you please update your sync process once and try using the image version(20250105.1). Let us know if you encounter any further issues. Thanks!

Prabhatkumar59 avatar Jan 20 '25 09:01 Prabhatkumar59

Hey @Prabhatkumar59,

It seems that platform-tools version 35.0.2 is still missing: https://github.com/SRGSSR/pillarbox-android/actions/runs/12886777098/job/35928089304

MGaetan89 avatar Jan 21 '25 12:01 MGaetan89

Yup, still missing on ubuntu image 20250105.1.0

Still only in the macOS and windows image scripts: https://github.com/search?q=repo%3Aactions%2Frunner-images%20platform-tools&type=code

yogurtearl avatar Jan 21 '25 16:01 yogurtearl

Hi @yogurtearl - Thanks for your input. We are investigating more into this and will update you. In mean time, a new version is going to roll out this week, i will update you on this. Appreciate your pateince. Thanks! cc: @MGaetan89

Prabhatkumar59 avatar Jan 22 '25 14:01 Prabhatkumar59

@Prabhatkumar59 can you point to the change where platform-tools is added to the ubuntu scripts?

Unless there is an explicit update to the ubuntu runner image scripts, platform-tools will not be in the new images.

yogurtearl avatar Jan 22 '25 15:01 yogurtearl

Hi @yogurtearl - We are looking into this and will update you shortly. Thanks!

Prabhatkumar59 avatar Jan 22 '25 16:01 Prabhatkumar59

According to this latest Ubuntu PR, it doesn't seem that platform-tools is included in version 20250126 of the Ubuntu images.

MGaetan89 avatar Jan 27 '25 14:01 MGaetan89

Hey @yogurtearl , @MGaetan89 , the platform-tools should become available after the next Ubuntu image rollout.

Alexey-Ayupov avatar Feb 06 '25 15:02 Alexey-Ayupov

Indeed, it seems to be part of https://github.com/actions/runner-images/pull/11565. I'll confirm once the update is deployed

MGaetan89 avatar Feb 10 '25 09:02 MGaetan89

I've had a couple of builds today triggered on the latest image (20250209.1) and platform-tools was included in the image now 🎉 Thanks for the update @Alexey-Ayupov!

MGaetan89 avatar Feb 12 '25 16:02 MGaetan89

Thanks for your patience. If you have any other questions feel free to reach us.

Alexey-Ayupov avatar Feb 14 '25 16:02 Alexey-Ayupov