languageservices icon indicating copy to clipboard operation
languageservices copied to clipboard

validation false-positives in diff editor

Open OmarTawfik opened this issue 1 year ago • 0 comments

This validation is very helpful when editing workflow files:

https://github.com/actions/languageservices/blob/4280a967a8aa058dd3c8825349b90bc932d82283/workflow-parser/src/model/convert.ts#L113

But unfortunately, it runs not only on opened VS Code editors, but on diff editors as well. And in diff editors, it triggers false positives on all relative file paths. Example:

image

I suspect this might be because diff editors have different file url scheme, so it is unable to consolidate that with file:// lookup? Additionally, it triggers on both the before and after file editors.

I wonder if it is possible to detect diff editors, and skip running this kind of validation when not possible? Thank you.

OmarTawfik avatar Feb 04 '24 15:02 OmarTawfik