labeler icon indicating copy to clipboard operation
labeler copied to clipboard

Branch name checks ignored as top level key

Open steverep opened this issue 1 year ago • 3 comments

Description: From the current documentation, I have no idea how this config is supposed to behave:

my-label:
  - changed-files:
    - ...
  - head-branch:
    - ...

When I read the docs, I expect it to behave as if both were under any, i.e. changed-files || head-branch. However it instead seems to completely ignore the head-branch config.

Action version: 5.0.0

Platform:

  • [x] Ubuntu
  • [ ] macOS
  • [ ] Windows

Runner type:

  • [x] Hosted
  • [ ] Self-hosted

Repro steps:
See https://github.com/home-assistant/frontend/pull/19321 where the action removed the "Dependencies" label despite the branch name matching. The debug log seems to indicate the branch name is not even checked:

https://github.com/home-assistant/frontend/actions/runs/7443800544/job/20458307412

Expected behavior: Expect it to behave like any:

Actual behavior: Ignores the head-branch check.

steverep avatar Jan 13 '24 04:01 steverep

After examining the debug logs, it appears as if branch name checks are simply ignored as top level keys. I've adjusted the OP and issue title accordingly.

steverep avatar Jan 14 '24 04:01 steverep

Hello @steverep Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.

HarithaVattikuti avatar Jan 16 '24 21:01 HarithaVattikuti

Hi @steverep  , Thank you for reporting this and sharing your observations! Based on my recent testing with a similar labeler config in the setup-actions-demo repository, the configuration for the Dependencies label appears to be working as expected. According to the documentation, if a base option is provided without a top-level key, it should default to any, which aligns with the observed behavior.

However, in your case, the dependabot bot added the Dependencies and GitHub Actions labels on Jan 8, 2024, but then the github-actions bot removed the Dependencies label shortly after. This may be due to configuration nuances or specific workflow behavior.

To help with further investigation: If you are currently experiencing this issue, could you please provide the debug logs from your workflow run where the unexpected label behavior occurs? This will help us better understand what’s happening.

Note: The debug logs previously attached to this issue appear to link to a "not found" page. Please ensure the logs are accessible or attach them directly to your comment.

How to enable debug logging: Add the following secrets to your repo:

  • ACTIONS_STEP_DEBUG set to true Then run your workflow and upload the resulting logs here. This additional information will help us pinpoint the cause and provide a more accurate solution.

Thanks for your help!

chiranjib-swain avatar Jun 25 '25 06:06 chiranjib-swain

Hi @steverep , just a gentle follow-up on this issue. Whenever you have a moment, your input or any updates would be appreciated. Please let us know if you need more details or assistance. Thank you!

chiranjib-swain avatar Jul 07 '25 05:07 chiranjib-swain

Hi @steverep, following up for the second time on this ticket. If you’ve had a chance to review, we’d appreciate any updates or feedback. If you need more information or assistance to move forward, please let us know. Thank you!

chiranjib-swain avatar Jul 22 '25 04:07 chiranjib-swain

باشه

در تاریخ سه‌شنبه ۲۲ ژوئیهٔ ۲۰۲۵،‏ ۰۸:۲۶ Chiranjib Swain < @.***> نوشت:

chiranjib-swain left a comment (actions/labeler#743) https://github.com/actions/labeler/issues/743#issuecomment-3100961478

Hi @steverep https://github.com/steverep, following up for the second time on this ticket. If you’ve had a chance to review, we’d appreciate any updates or feedback. If you need more information or assistance to move forward, please let us know. Thank you!

— Reply to this email directly, view it on GitHub https://github.com/actions/labeler/issues/743#issuecomment-3100961478, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2UH5BLDYYKC4RS7T2XMWVL3JW77FAVCNFSM6AAAAACACH4K5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMBQHE3DCNBXHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

saeidkhasteh avatar Jul 23 '25 04:07 saeidkhasteh

Hi @steverep , Could you please provide an update or let us know if you need any further clarification or assistance? Your feedback will help us move forward. Thank you!

chiranjib-swain avatar Aug 05 '25 07:08 chiranjib-swain

Thanks for your feedback. As noted above, the necessary information has been provided, so I’m closing this issue. If you have further questions, feel free to reopen or open a new issue.

chiranjib-swain avatar Aug 13 '25 09:08 chiranjib-swain