labeler
labeler copied to clipboard
actions
Added output
In order to use this action as one step in a series of steps in a workflow (and use the changed labels as input to downstream actions), this PR outputs the added labels and all labels as output to the action.
outputs:
new-labels:
description: 'List of all new labels'
all-labels:
description: 'List of all labels'
The only changes here are the new definition of the output and piping the new labels and all labels (taken from the result of the API call) and sending them as output via core.setOutput
This is a really useful change, and I'd like to see it merged.
The formatting changes obscure the actual meat of the changes, and might (?) make it less likely to be merged. I imagine that you're using prettier, and this repo should be too to avoid this kinda thing. Would you mind updating your PR with the formatting changes reverted?
Good point. I've removed all the formatting changes.
This is a useful contribution. Any chance of fixing the merge conflict and getting it merged?
This is a useful contribution. Any chance of fixing the merge conflict and getting it merged?
I would also like to see this merged, unfortunately I haven't heard anything from the maintainers of this repo. I already updated the formatting per @keithlayne 's suggestion, but still haven't heard anything. If a maintainer says they'd like to merge this change and need me to resolve the conflict, I'll do it. But I won't be continuously updating this PR on the off chance that someone sees it.
If you are a maintainer of this repo, please let me know if you'd like to see this merged.
Hey @danielsht86, thanks for the contribution! I took the liberty of updating your branch from main, resolving conflicts, and pushing the changes.
I'm happy to see this merged—I'd like to get 1) tests, and 2) some mention of outputs added to the docs, at least the README.
👍
Is it possible to get this merged in? It would be very helpful 😄 I need it for the exact case pointed out by https://github.com/actions/labeler/issues/59#issuecomment-697238514
On initial push to the repo, I changed api and web files but the actions cannot run because the labels aren't up to date at the time they are checked.
Does anyone have a workaround while this PR is waiting to be merged?
https://github.com/actions/labeler/pull/408
I've included the changes in the default branch of my fork and rebased the major version tag, so you could use it from there.
I'd document new outputs as well as examples of their use in a chapter of the README.md, I think mentioning them in the action.yml alone is not enough.
Thank you @danielsht86 for the contribution! Thank you all for your patience!
