Implement dot option

[kachkaev]

Closes #135

[kachkaev]

@pje, @cory-miller, @rentziass, @thboop 🙏

[ivoanjo]

+1 Thanks for fixing this, and it would be great if this was merged in. I work at Datadog and we're using this in our repositories (see https://github.com/DataDog/dd-trace-rb/pull/2291/).

[kachkaev]

@panticmilos @marko-zivic-93 🙏

[panticmilos]

hi @kachkaev, we will take a look at this PR :)

[smorimoto]

When will this be fixed? It's a fundamental issue, and it's unbelievable that you're still left to fix.

[smorimoto]

Is there anyone on the actions-runtime team who can review this changes?

[panticmilos]

Hi @smorimoto, we will review it in the following days, thank you for your patience.

[smorimoto]

Great! I hope this "fix" is released soon 🙂

[smorimoto]

Status?

[smorimoto]

@panticmilos hi?

[kachkaev]

PR reviews in open-source repos may take time; this is normal. If you are blocked, feel free to configure your codebase with a forked action, which already supports dot: true:

name: Pull Request Labeler
on:
  - pull_request_target

jobs:
  triage:
    runs-on: ubuntu-22.04

    steps:
      - uses: kachkaev/labeler@012b89238e3fa57d7af8ee028f02be6d421f184f
        ## @todo replace with actions/labeler@v4 (or newer) when this PR is merged:
        ## https://github.com/actions/labeler/pull/316
        with:
          dot: true
          repo-token: "${{ secrets.GITHUB_TOKEN }}"

Doing so will make your labeler.yaml more concise and can also help us with testing.

If this PRs gets futher updates, you can replace a7cc8a62ef0fcdcf8ff1516986c74c7f46ef6fa4 with the most recent commit you will find on this page.

[smorimoto]

I totally get it, but sometimes things don't move forward unless we push it. This was particularly evident in my experience working with the GHA platform 🙂

[kachkaev]

@IvanZosimov, @panticmilos I just synced my branch with the latest main, all tests pass locally. How can I help with getting this PR in? The change is non-breaking and has been approved by @dsame a few months ago.

[kachkaev]

What else are we missing before the PR can be merged? 🙏

[smorimoto]

I'm glad that this has finally been merged. Thank you for everyone's efforts! 🙂

[kachkaev]

v4.1.0 is out with this new option 🎉

If anyone has been using my fork, please switch back to the official labeler action:

-      - uses: kachkaev/labeler@012b89238e3fa57d7af8ee028f02be6d421f184f
-       ## @todo replace with actions/labeler@v4 (or newer) when this PR is merged:
-       ## https://github.com/actions/labeler/pull/316
+     - uses: actions/labeler@v4
        with:
          dot: true

My fork will not receive any updates and I plan to delete it in a couple of months. This means that workflows using kachkaev/labeler will eventually break.

I suggest to make dot: true the default value in actions/labeler@v5 – see https://github.com/actions/labeler/issues/575#issuecomment-1576485690. Happy to create a follow-up PR if this makes sense.

[MaksimZhukov]

@kachkaev thanks for your time and contribution! Thank you all for your patience!

[kachkaev]

The dot option is true by default in v5 🎉 Release notes: https://github.com/actions/labeler/releases/tag/v5.0.0