labeler icon indicating copy to clipboard operation
labeler copied to clipboard

glob syntax is not intuitive, readme not specific enough

Open Gornoka opened this issue 3 years ago • 2 comments

In my opinion the readme does not specify clearly enough how globs should be specified, especially when they start with a wildcard.

~My problem was that " like it is used in the workflow definition yields to blobs being not recognized.~

~A comment in the readme , that using " (like in the action for branch filtering) instead of ' will crash the action would be very nice to have.~ A comment that leading wildcards without " or ' will crash the action would be nice to have. Kind regards Lukas

update: when testing more i found out that apparently sometimes " work, but i have no idea why they did not at other times. the only thing that i have found that consistently does not work is blank globs without either ' or " and wildcards at the beginning.

#works
python:
- '**/*.py'
# crashes
# python:
# - **/*.py
# works
python:
- "**/*.py"

Gornoka avatar Dec 03 '21 17:12 Gornoka

An asterisk has a special meaning in yaml. That's why you need to quote it. https://yaml.org/spec/1.2-old/spec.html#id2760395

Repeated nodes (objects) are first identified by an anchor (marked with the ampersand - “&”), and are then aliased (referenced with an asterisk - “*”) thereafter.

T3rm1 avatar Feb 18 '22 07:02 T3rm1

I am closing this issue since the related PR was merged. Please contact us if you have any questions.

MaksimZhukov avatar Dec 26 '22 11:12 MaksimZhukov