labeler icon indicating copy to clipboard operation
labeler copied to clipboard

Suggestion: auto-update dist/index.js on main branch

Open ericcornelissen opened this issue 5 years ago • 3 comments

This is a suggestion to change the way contributing to this project works. Currently, when a PR is submitted the submitter has to run npm run build and include the changes to dist/index.js in the PR. With the changes in this PR, including the changes to dist/index.js is no longer necessary (*). This should avoid a bunch of merge conflicts with regards to the dist/index.js file - even though they're simple to fix it is annoying you have to. I updated the contributing guidelines accordingly, ~~removing~~ editing the fourth step of "Submitting a Pull Request".

(*): It is still possible though, and if a PR is merged with updates to lib/ included, the changes in this PR won't have any effect.

ericcornelissen avatar Nov 27 '20 19:11 ericcornelissen

@ericcornelissen I broadly agree, and I sketched out the implementation here: https://github.com/actions/labeler/pull/155

Comments/improvements welcome!

pje avatar Jun 17 '21 19:06 pje

While similar, @pje, it seems #155 does something slightly different, so I'm not sure what you're getting at with your comment :thinking:

That being said, #155 looks great!

ericcornelissen avatar Jun 17 '21 21:06 ericcornelissen

@ericcornelissen right, what I meant is: that PR is the same principle ("automatically commit machine-generated changes in response to changes to a specific file"), just with different targets. 👍

pje avatar Jun 18 '21 14:06 pje