first-interaction icon indicating copy to clipboard operation
first-interaction copied to clipboard

Support Messaging on first merge PR

Open brucearctor opened this issue 1 year ago • 10 comments

Would this be the correct GH Action to also have a message on first merge of a PR? Or that would be after the 'first interaction' and therefore something better off elsewhere?

I would be happy to extend this action to include messaging on FirstPRMerge. Like: https://github.com/behaviorbot/welcome#first-pr-merge

If I submitted a PR is that something that would be welcome/reviewed/included? Or outside the scope of this GH Action?

brucearctor avatar Feb 21 '23 18:02 brucearctor

Hello! Thank you for filing an issue.

If this is a bug report, please include relevant logs to help us debug the problem.

github-actions[bot] avatar Feb 21 '23 18:02 github-actions[bot]

+1, this would be a nice addition

kartben avatar Mar 22 '23 11:03 kartben

Hey actually I just ended up implementing the change -- see https://github.com/kartben/first-interaction/tree/v1.1.2-fork. This will greet someone on their first merged PR (which might not be their first PR ever, but really the first that's being merged into the repo)

I will echo @brucearctor question, and ask if someone from the project would like me to submit a PR? If that's the case indeed, I'm realizing just now that my fork might require a few changes to make sure that the new version actually remains backward-compatible, i.e. I probably should refrain from renaming message keys.

@cory-miller @TingluoHuang

kartben avatar Mar 22 '23 17:03 kartben

Awesome! FYI -> I'm hoping to use for some messaging around: https://news.apache.org/foundation/entry/the-asf-launches-firstasfcontribution-campaign. [ in some specific ASF projects ] ... there is some opposition/hesitation to use probot, so this would be great to use!

brucearctor avatar Mar 22 '23 18:03 brucearctor

Awesome! FYI -> I'm hoping to use for some messaging around: https://news.apache.org/foundation/entry/the-asf-launches-firstasfcontribution-campaign. [ in some specific ASF projects ] ... there is some opposition/hesitation to use probot, so this would be great to use!

Very cool! FWIW here's what I have drafted for our open-source project: https://github.com/kartben/delete-me4/blob/main/.github/workflows/blank.yml, in case this is useful to you somehow :)

kartben avatar Mar 22 '23 18:03 kartben

Wait, I accept the fact that what the organization that you guys are doing, I don't know anything, I don't have the ability, but I want to be involved, I want to be a discount, I want to be able to work with you without getting stuck in communicating information, I need time to learn, maybe I understand something difficult, sorry in advance, this encryption is something I use, but I still don't understand anything, I think you guys wouldn't have done anything that would have damaged me, if I had done it a long time ago, I didn't feel that I was at risk in terms of things. それは私自身のスティントです。

ในวันที่ พฤ. 23 มี.ค. 2023 01:11 น. brucearctor @.***> เขียนว่า:

Awesome! FYI -> I'm hoping to use for some messaging around: https://news.apache.org/foundation/entry/the-asf-launches-firstasfcontribution-campaign ... there is some opposition/hesitation to use probot, so this would be great to use!

— Reply to this email directly, view it on GitHub https://github.com/actions/first-interaction/issues/226#issuecomment-1480040507, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZHZVEZFLZGB7NULQG52LQTW5M6FJANCNFSM6AAAAAAVDMMJME . You are receiving this because you are subscribed to this thread.Message ID: @.***>

The11sun avatar Mar 22 '23 18:03 The11sun

My meaning is to allow you to do what you think is worthy of doing it with my approval, because sometimes the program is not able to convey my feelings, I am willing to let you do anything because I think you have not damaged me in the past, but I have benefited from the knowledge gained more like you than thank you.

それは私自身のスティントです。

ในวันที่ พฤ. 23 มี.ค. 2023 01:25 น. Tawan Srithong < @.***> เขียนว่า:

Wait, I accept the fact that what the organization that you guys are doing, I don't know anything, I don't have the ability, but I want to be involved, I want to be a discount, I want to be able to work with you without getting stuck in communicating information, I need time to learn, maybe I understand something difficult, sorry in advance, this encryption is something I use, but I still don't understand anything, I think you guys wouldn't have done anything that would have damaged me, if I had done it a long time ago, I didn't feel that I was at risk in terms of things. それは私自身のスティントです。

ในวันที่ พฤ. 23 มี.ค. 2023 01:11 น. brucearctor @.***> เขียนว่า:

Awesome! FYI -> I'm hoping to use for some messaging around: https://news.apache.org/foundation/entry/the-asf-launches-firstasfcontribution-campaign ... there is some opposition/hesitation to use probot, so this would be great to use!

— Reply to this email directly, view it on GitHub https://github.com/actions/first-interaction/issues/226#issuecomment-1480040507, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZHZVEZFLZGB7NULQG52LQTW5M6FJANCNFSM6AAAAAAVDMMJME . You are receiving this because you are subscribed to this thread.Message ID: @.***>

The11sun avatar Mar 22 '23 18:03 The11sun

ping @cory-miller @TingluoHuang. I'd rather not fork the action if you guys would be considering a PR for this (as a reminder, the branch lives here: https://github.com/kartben/first-interaction/tree/v1.1.2-fork)

Thank you!

kartben avatar Mar 28 '23 09:03 kartben

FWIW the Zephyr Project went ahead and will be using this fork going forward: https://github.com/zephyrproject-rtos/action-first-interaction/tree/v1.1.2-zephyr. I would still very much be interested in contributing this functionality back upstream if there is interest?

kartben avatar Apr 11 '23 16:04 kartben

Hi @kartben , I was looking into this first merged greet message action and since the github action doesn't allows it for now, can you please guide me on how to use https://github.com/kartben/first-interaction/tree/v1.1.2-fork on my project repo. Thanks.

Swastyy avatar Mar 04 '24 05:03 Swastyy